From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ
Date: Sat, 10 Apr 2010 09:56:47 +0200 [thread overview]
Message-ID: <4BC02F3F.7050901@redhat.com> (raw)
In-Reply-To: <n2ufbd9d3991004092304me046dc54oe91072d6f4a109bd@mail.gmail.com>
Am 10.04.2010 08:04, schrieb Stefan Hajnoczi:
> On Fri, Apr 9, 2010 at 7:17 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> I see three options:
>> 1. Leave the search.
>> 2. Modify qemu-queue.h to add a QTAILQ_ON_LIST(elm) macro.
>> 3. Break the QTAILQ abstraction and test tge_prev directly.
>
> I see a nicer option: check device_name[0]. Patch v2 sent.
Yup, this is exactly what I was just about to suggest.
Of course, QTAILQ_ON_LIST would be nice to have either, but I'm afraid
it's not possible without putting the loop into that macro.
Kevin
prev parent reply other threads:[~2010-04-10 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 14:22 [Qemu-devel] [PATCH 0/2] block: Cleanups Stefan Hajnoczi
2010-04-09 14:22 ` [Qemu-devel] [PATCH 1/2] block: Do not export bdrv_first Stefan Hajnoczi
2010-04-09 16:50 ` Kevin Wolf
2010-04-09 14:22 ` [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ Stefan Hajnoczi
2010-04-09 16:47 ` Kevin Wolf
2010-04-09 18:17 ` Stefan Hajnoczi
2010-04-10 6:04 ` Stefan Hajnoczi
2010-04-10 7:56 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC02F3F.7050901@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).