From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
Juergen Lock <nox@jelal.kn-bremen.de>
Subject: [Qemu-devel] Re: [PATCH] Avoid compiler error
Date: Sat, 10 Apr 2010 11:43:39 -0700 [thread overview]
Message-ID: <4BC0C6DB.5060703@twiddle.net> (raw)
In-Reply-To: <1270884363-5186-1-git-send-email-weil@mail.berlios.de>
On 04/10/2010 12:26 AM, Stefan Weil wrote:
> A 32 bit cross compilation of x86_64-linux-user raises this error:
> } else {
> #if TARGET_ABI_BITS<= L1_MAP_ADDR_SPACE_BITS
> endaddr = ~0ul;
> +#elif HOST_LONG_BITS<= L1_MAP_ADDR_SPACE_BITS
> + endaddr = ULONG_MAX;
> #else
> endaddr = ((abi_ulong)1<< L1_MAP_ADDR_SPACE_BITS) - 1;
> #endif
You ought to merge those two ifs. I.e.
#if TARGET_ABI_BITS <= L1_MAP_ADDR_SPACE_BITS \
|| HOST_LONG_BITS<= L1_MAP_ADDR_SPACE_BITS
r~
prev parent reply other threads:[~2010-04-10 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 7:26 [Qemu-devel] [PATCH] Avoid compiler error Stefan Weil
2010-04-10 15:15 ` [Qemu-devel] " Aurelien Jarno
2010-04-10 18:43 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC0C6DB.5060703@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=nox@jelal.kn-bremen.de \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).