From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0ff1-0002EC-2X
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 14:44:03 -0400
Received: from [140.186.70.92] (port=46622 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0fez-0002Co-Re
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 14:44:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1O0fez-0000vU-0L
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 14:44:01 -0400
Received: from mail-yw0-f198.google.com ([209.85.211.198]:51496)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1O0fey-0000vC-TM
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 14:44:00 -0400
Received: by ywh36 with SMTP id 36so1977278ywh.4
	for <qemu-devel@nongnu.org>; Sat, 10 Apr 2010 11:43:59 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4BC0C6DB.5060703@twiddle.net>
Date: Sat, 10 Apr 2010 11:43:39 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1270884363-5186-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1270884363-5186-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Avoid compiler error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, Juergen Lock <nox@jelal.kn-bremen.de>

On 04/10/2010 12:26 AM, Stefan Weil wrote:
> A 32 bit cross compilation of x86_64-linux-user raises this error:
>                       } else {
>   #if TARGET_ABI_BITS<= L1_MAP_ADDR_SPACE_BITS
>                           endaddr = ~0ul;
> +#elif HOST_LONG_BITS<= L1_MAP_ADDR_SPACE_BITS
> +                        endaddr = ULONG_MAX;
>   #else
>                           endaddr = ((abi_ulong)1<<  L1_MAP_ADDR_SPACE_BITS) - 1;
>   #endif

You ought to merge those two ifs.  I.e.


#if TARGET_ABI_BITS <= L1_MAP_ADDR_SPACE_BITS \
     || HOST_LONG_BITS<= L1_MAP_ADDR_SPACE_BITS


r~