From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O12sf-0006HM-N2
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 15:31:41 -0400
Received: from [140.186.70.92] (port=43127 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O12se-0006Gg-7q
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 15:31:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O12sc-00064K-NC
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 15:31:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41302)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O12sc-00064B-ES
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 15:31:38 -0400
Message-ID: <4BC2238C.2070009@redhat.com>
Date: Sun, 11 Apr 2010 22:31:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1271013662-7640-1-git-send-email-andre.przywara@amd.com>
In-Reply-To: <1271013662-7640-1-git-send-email-andre.przywara@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH][STABLE] fix CPUID vendor override
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andre Przywara <andre.przywara@amd.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 04/11/2010 10:21 PM, Andre Przywara wrote:
> the meaning of vendor_override is actually the opposite of how it
> is currently used :-(
> Fix it to allow KVM to export the non-native CPUID vendor if
> explicitly requested by the user.
>
> Signed-off-by: Andre Przywara<andre.przywara@amd.com>
> ---
>   target-i386/helper.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> I will send a refactoring patch including this fix for git HEAD later.
>
> Regards,
> Andre.
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 9d7fec3..c17adc1 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1655,7 +1655,7 @@ static void get_cpuid_vendor(CPUX86State *env, uint32_t *ebx,
>        * this if you want to use KVM's sysenter/syscall emulation
>        * in compatibility mode and when doing cross vendor migration
>        */
> -    if (kvm_enabled()&&  env->cpuid_vendor_override) {
> +    if (kvm_enabled()&&  ! env->cpuid_vendor_override) {
>           host_cpuid(0, 0, NULL, ebx, ecx, edx);
>       }
>   }
>    

Why is the original code wrong?  I would say vendor_override means 
overriding the qemu-picked vendor ID in favour of the host cpuid.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.