From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O16Ev-0001Cf-Sy
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 19:06:53 -0400
Received: from [140.186.70.92] (port=58419 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O16Eo-0001C8-Sh
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 19:06:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1O16Dq-00083E-1w
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 19:05:47 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:56107)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1O16Dp-00083A-Ud
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 19:05:46 -0400
Received: by gyd5 with SMTP id 5so2580762gyd.4
	for <qemu-devel@nongnu.org>; Sun, 11 Apr 2010 16:05:44 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4BC255B8.3080606@twiddle.net>
Date: Sun, 11 Apr 2010 16:05:28 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's
	2nd arg.
References: <201004101709.o3AH9vx8029942@smtp12.dti.ne.jp>
In-Reply-To: <201004101709.o3AH9vx8029942@smtp12.dti.ne.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: takasi-y@ops.dti.ne.jp
Cc: qemu-devel@nongnu.org

On 04/10/2010 10:09 AM, takasi-y@ops.dti.ne.jp wrote:
> 2nd arg of page_set_flags() should be start+size, but size.
>
> Signed-off-by: Takashi YOSHII<takasi-y@ops.dti.ne.jp>

Acked-by: Richard Henderson <rth@twiddle.net>


> ---
>   linux-user/syscall.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a03e432..26c0fb4 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2752,7 +2752,7 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
>       for (i = 0; i<  N_SHM_REGIONS; ++i) {
>           if (shm_regions[i].start == shmaddr) {
>               shm_regions[i].start = 0;
> -            page_set_flags(shmaddr, shm_regions[i].size, 0);
> +            page_set_flags(shmaddr, shmaddr + shm_regions[i].size, 0);
>               break;
>           }
>       }