* [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg.
@ 2010-04-10 17:09 takasi-y
2010-04-11 23:05 ` Richard Henderson
2010-04-13 22:19 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: takasi-y @ 2010-04-10 17:09 UTC (permalink / raw)
To: qemu-devel
2nd arg of page_set_flags() should be start+size, but size.
Signed-off-by: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
---
linux-user/syscall.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a03e432..26c0fb4 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2752,7 +2752,7 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
for (i = 0; i < N_SHM_REGIONS; ++i) {
if (shm_regions[i].start == shmaddr) {
shm_regions[i].start = 0;
- page_set_flags(shmaddr, shm_regions[i].size, 0);
+ page_set_flags(shmaddr, shmaddr + shm_regions[i].size, 0);
break;
}
}
--
1.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg.
2010-04-10 17:09 [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg takasi-y
@ 2010-04-11 23:05 ` Richard Henderson
2010-04-13 22:19 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2010-04-11 23:05 UTC (permalink / raw)
To: takasi-y; +Cc: qemu-devel
On 04/10/2010 10:09 AM, takasi-y@ops.dti.ne.jp wrote:
> 2nd arg of page_set_flags() should be start+size, but size.
>
> Signed-off-by: Takashi YOSHII<takasi-y@ops.dti.ne.jp>
Acked-by: Richard Henderson <rth@twiddle.net>
> ---
> linux-user/syscall.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a03e432..26c0fb4 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2752,7 +2752,7 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
> for (i = 0; i< N_SHM_REGIONS; ++i) {
> if (shm_regions[i].start == shmaddr) {
> shm_regions[i].start = 0;
> - page_set_flags(shmaddr, shm_regions[i].size, 0);
> + page_set_flags(shmaddr, shmaddr + shm_regions[i].size, 0);
> break;
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg.
2010-04-10 17:09 [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg takasi-y
2010-04-11 23:05 ` Richard Henderson
@ 2010-04-13 22:19 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-04-13 22:19 UTC (permalink / raw)
To: takasi-y; +Cc: qemu-devel
On Sun, Apr 11, 2010 at 02:09:57AM +0900, takasi-y@ops.dti.ne.jp wrote:
> 2nd arg of page_set_flags() should be start+size, but size.
>
> Signed-off-by: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Thanks, applied.
> ---
> linux-user/syscall.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a03e432..26c0fb4 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2752,7 +2752,7 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
> for (i = 0; i < N_SHM_REGIONS; ++i) {
> if (shm_regions[i].start == shmaddr) {
> shm_regions[i].start = 0;
> - page_set_flags(shmaddr, shm_regions[i].size, 0);
> + page_set_flags(shmaddr, shmaddr + shm_regions[i].size, 0);
> break;
> }
> }
> --
> 1.6.5
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-13 22:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-10 17:09 [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg takasi-y
2010-04-11 23:05 ` Richard Henderson
2010-04-13 22:19 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).