From: Kevin Wolf <kwolf@redhat.com>
To: Bruce Rogers <brogers@novell.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove un-needed code
Date: Mon, 12 Apr 2010 15:08:13 +0200 [thread overview]
Message-ID: <4BC31B3D.3050704@redhat.com> (raw)
In-Reply-To: <4BC2C4000200004800092C4D@sinclair.provo.novell.com>
Am 12.04.2010 14:56, schrieb Bruce Rogers:
> The bdrv_set_geometry_hint call below is not needed - it's just setting what was just read.
>
> Signed-off-by: Bruce Rogers <brogers@novell.com >
Almost. ;-) I fixed that additional space for you and applied the patch
to the block branch.
Kevin
>
> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
> index 9915840..bc4fa77 100644
> --- a/hw/virtio-blk.c
> +++ b/hw/virtio-blk.c
> @@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf)
> s->rq = NULL;
> s->sector_mask = (s->conf->logical_block_size / 512) - 1;
> bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs);
> - bdrv_set_geometry_hint(s->bs, cylinders, heads, secs);
>
> s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output);
>
>
>
>
next prev parent reply other threads:[~2010-04-12 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 12:56 [Qemu-devel] [PATCH] Remove un-needed code Bruce Rogers
2010-04-12 13:08 ` Kevin Wolf [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-09 22:55 Bruce Rogers
2010-04-12 8:53 ` Kevin Wolf
2010-04-12 13:02 ` Bruce Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC31B3D.3050704@redhat.com \
--to=kwolf@redhat.com \
--cc=brogers@novell.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).