* [Qemu-devel] [PATCH] Remove un-needed code
@ 2010-04-12 12:56 Bruce Rogers
2010-04-12 13:08 ` Kevin Wolf
0 siblings, 1 reply; 5+ messages in thread
From: Bruce Rogers @ 2010-04-12 12:56 UTC (permalink / raw)
To: qemu-devel
The bdrv_set_geometry_hint call below is not needed - it's just setting what was just read.
Signed-off-by: Bruce Rogers <brogers@novell.com >
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 9915840..bc4fa77 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf)
s->rq = NULL;
s->sector_mask = (s->conf->logical_block_size / 512) - 1;
bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs);
- bdrv_set_geometry_hint(s->bs, cylinders, heads, secs);
s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Remove un-needed code
2010-04-12 12:56 [Qemu-devel] [PATCH] Remove un-needed code Bruce Rogers
@ 2010-04-12 13:08 ` Kevin Wolf
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2010-04-12 13:08 UTC (permalink / raw)
To: Bruce Rogers; +Cc: qemu-devel
Am 12.04.2010 14:56, schrieb Bruce Rogers:
> The bdrv_set_geometry_hint call below is not needed - it's just setting what was just read.
>
> Signed-off-by: Bruce Rogers <brogers@novell.com >
Almost. ;-) I fixed that additional space for you and applied the patch
to the block branch.
Kevin
>
> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
> index 9915840..bc4fa77 100644
> --- a/hw/virtio-blk.c
> +++ b/hw/virtio-blk.c
> @@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf)
> s->rq = NULL;
> s->sector_mask = (s->conf->logical_block_size / 512) - 1;
> bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs);
> - bdrv_set_geometry_hint(s->bs, cylinders, heads, secs);
>
> s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output);
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] Remove un-needed code
@ 2010-04-09 22:55 Bruce Rogers
2010-04-12 8:53 ` Kevin Wolf
0 siblings, 1 reply; 5+ messages in thread
From: Bruce Rogers @ 2010-04-09 22:55 UTC (permalink / raw)
To: qemu-devel
The set_geometry_hint call below is not needed - it's just setting what was just read.
Signed-Off-By: Bruce Rogers <brogers@novell.com
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 9915840..bc4fa77 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *c
onf)
s->rq = NULL;
s->sector_mask = (s->conf->logical_block_size / 512) - 1;
bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs);
- bdrv_set_geometry_hint(s->bs, cylinders, heads, secs);
s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Remove un-needed code
2010-04-09 22:55 Bruce Rogers
@ 2010-04-12 8:53 ` Kevin Wolf
2010-04-12 13:02 ` Bruce Rogers
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Wolf @ 2010-04-12 8:53 UTC (permalink / raw)
To: Bruce Rogers; +Cc: qemu-devel
Am 10.04.2010 00:55, schrieb Bruce Rogers:
> The set_geometry_hint call below is not needed - it's just setting what was just read.
>
> Signed-Off-By: Bruce Rogers <brogers@novell.com
It needs to be "Signed-off-by" with lower-case o and b to be recognized
by git, and the right angle bracket is missing.
>
> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
> index 9915840..bc4fa77 100644
> --- a/hw/virtio-blk.c
> +++ b/hw/virtio-blk.c
> @@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *c
> onf)
Patch is incorrectly wrapped here.
> s->rq = NULL;
> s->sector_mask = (s->conf->logical_block_size / 512) - 1;
> bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs);
> - bdrv_set_geometry_hint(s->bs, cylinders, heads, secs);
>
> s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output);
bdrv_guess_geometry is not a simple getter function, but it already
calls bdrv_set_geometry_hint itself, so I think the logic is correct.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Remove un-needed code
2010-04-12 8:53 ` Kevin Wolf
@ 2010-04-12 13:02 ` Bruce Rogers
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Rogers @ 2010-04-12 13:02 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On 4/12/2010 at 2:53 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 10.04.2010 00:55, schrieb Bruce Rogers:
>> The set_geometry_hint call below is not needed - it's just setting what was
> just read.
>>
>> Signed-Off-By: Bruce Rogers <brogers@novell.com
>
> It needs to be "Signed-off-by" with lower-case o and b to be recognized
> by git, and the right angle bracket is missing.
>
>>
>> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
>> index 9915840..bc4fa77 100644
>> --- a/hw/virtio-blk.c
>> +++ b/hw/virtio-blk.c
>> @@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf
> *c
>> onf)
>
> Patch is incorrectly wrapped here.
>
>> s->rq = NULL;
>> s->sector_mask = (s->conf->logical_block_size / 512) - 1;
>> bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs);
>> - bdrv_set_geometry_hint(s->bs, cylinders, heads, secs);
>>
>> s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output);
>
> bdrv_guess_geometry is not a simple getter function, but it already
> calls bdrv_set_geometry_hint itself, so I think the logic is correct.
>
> Kevin
I've re-posted with these items fixed. Thanks.
Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-04-12 13:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-12 12:56 [Qemu-devel] [PATCH] Remove un-needed code Bruce Rogers
2010-04-12 13:08 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2010-04-09 22:55 Bruce Rogers
2010-04-12 8:53 ` Kevin Wolf
2010-04-12 13:02 ` Bruce Rogers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).