From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1KAB-00044z-PX for qemu-devel@nongnu.org; Mon, 12 Apr 2010 09:58:55 -0400 Received: from [140.186.70.92] (port=52107 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1KA8-00043t-VT for qemu-devel@nongnu.org; Mon, 12 Apr 2010 09:58:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1KA6-0007Vd-9J for qemu-devel@nongnu.org; Mon, 12 Apr 2010 09:58:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3131) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1KA6-0007Ui-17 for qemu-devel@nongnu.org; Mon, 12 Apr 2010 09:58:50 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3CDwjIc028784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Apr 2010 09:58:46 -0400 Message-ID: <4BC326A2.7050909@redhat.com> Date: Mon, 12 Apr 2010 09:56:50 -0400 From: Chris Lalancette MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [libvirt] Libvirt debug API References: <4BBF2E93.3020508@redhat.com> <20100409142717.GA11875@redhat.com> <4BBF6EE6.5080803@redhat.com> <20100412124110.GA9987@redhat.com> In-Reply-To: <20100412124110.GA9987@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Libvirt , Jiri Denemark , qemu-devel@nongnu.org On 04/12/2010 08:41 AM, Daniel P. Berrange wrote: >>> I don't think there's much to be gained from having an XML element to >>> turn on/off use of these APIs. If an app doesn't want to use them, it >>> can simply not link to libvirt-qemu.so >> >> The reason I wanted to do this was mostly for debug/support reasons. >> That is, with this element in place we can easily tell from the dumpxml >> output whether a person was using the "unreliable" API's, and thus we can >> tell them to try and reproduce without that in place. > > That doesn't tell you whether they have actually used any API or not. > It is also inconvenient if you start a guest without it, and only later > realize you want to use the extra APIs. If we want to track the actual > usage, then the first time a direct monitor command is issued, we should > simply log a warning message. The problem with logging a message is that it is easy to lose it. What I'm trying to avoid here is debugging somebody's setup for hours only to find out that they did a "pci_del" behind libvirt's back. Maybe we can just make the a read-only flag; it is ignored in the parsing, but it is set by "GetXMLDesc" when it detects that the virDomainQemuInvokeMonitor has been called. -- Chris Lalancette