From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O1zDE-0001fd-2n
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 05:48:48 -0400
Received: from [140.186.70.92] (port=42085 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O1zD3-0001em-Na
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 05:48:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1O1wxX-0007DE-37
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 03:24:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10156)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1O1wxO-0007Bf-2v
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 03:24:23 -0400
Message-ID: <4BC56D9A.7010606@redhat.com>
Date: Wed, 14 Apr 2010 09:24:10 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using
	-device parm
References: <4BC482850200004800092E82@sinclair.provo.novell.com>
In-Reply-To: <4BC482850200004800092E82@sinclair.provo.novell.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bruce Rogers <brogers@novell.com>
Cc: qemu-devel@nongnu.org

   Hi,

> When specifying ide devices using -device, the cmos information
> which the bios depends on is not written. This patch generalizes
> the cmos hd data setting for the existing code path and adds the
> ability to call that code on a per machine, per ide drive basis.

Hmm.

With -device and thus alot of device setup happening after 
QEMUMachine->init() I think it would be very useful to have 
QEMUMachine->init_late().  There are a bunch of machine specific jobs 
which need to be done after all devices have been plugged into the machine.

Setting up cmos is one of them.

i440fx_init_memory_mappings() could be moved there, which would allow to 
add vga cards via -device.

And I'm pretty sure there are more use cases.  fw_cfg maybe?

Comments?

cheers,
   Gerd