From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O2BnF-00031D-S9
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:14:51 -0400
Received: from [140.186.70.92] (port=53258 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O2Bn3-0002Y3-Fv
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:14:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1O2Bgo-00025D-IV
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:08:11 -0400
Received: from fg-out-1718.google.com ([72.14.220.159]:27905)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1O2Bgo-00024m-B0
	for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:08:10 -0400
Received: by fg-out-1718.google.com with SMTP id 22so244400fge.10
	for <qemu-devel@nongnu.org>; Wed, 14 Apr 2010 16:08:08 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4BC64AD6.6040209@redhat.com>
Date: Thu, 15 Apr 2010 01:08:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1271238922-10008-1-git-send-email-kraxel@redhat.com>	<1271238922-10008-9-git-send-email-kraxel@redhat.com>
	<z2xf43fc5581004140952uc68eabccoa9e9f35d6c83d5fe@mail.gmail.com>
In-Reply-To: <z2xf43fc5581004140952uc68eabccoa9e9f35d6c83d5fe@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RfC PATCH 08/11] spice: add qxl device
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On 04/14/2010 06:52 PM, Blue Swirl wrote:
> On 4/14/10, Gerd Hoffmann<kraxel@redhat.com>  wrote:
>>   +static inline void atomic_or(uint32_t *var, uint32_t add)
>>   +{
>>   +   __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add) : "memory");
>>   +}
>
> This will break on non-x86 hosts.

I'd just use __sync_fetch_and_or here.

Paolo