[Qemu-devel] Call for help in reviewing patches (!kvm & linux-user)

[Qemu-devel] Call for help in reviewing patches (!kvm & linux-user)

[Aurelien Jarno]

Hi all,

My impression is that few persons have interest in linux-user or 
non-KVM targets areas, at least from the development point of view.
I personally don't care about linux-user code, though I have tried to
merge patches in this area anyway, as otherwise they are just 
bitrotting on the mailing list.

On the other hand there are quite more people at least following the
development in these areas, as when something is broken, you are usually
told that quite quickly.

The result is that most of the patches I am merging have been reviewed
only by me. This is not very good from the quality point of view, more 
people reviewing the code, means less risk of breakage. Reviewing 
patches also takes a lot of time, and it is very frustrating for me to
spend most of my time on QEMU merging patches, while I would also like 
to spend time writing QEMU code instead. Some days when I open my mail
client on the QEMU folder and see a few patch series posted, I just want
to close it asap.

This is therefore a call for help. If you want patches to get merged
more quickly, and with less risk of breakage, don't hesitate to review
patches posted on the mailing list, and send your comments or an
Acked-by:. This really helps when reviewing the patches.

Aurelien

PS: This is not directed to any person, and some persons are already 
    doing that, but it's just not enough.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

[Qemu-devel] Re: Call for help in reviewing patches (!kvm & linux-user)

[Paolo Bonzini]

On 04/15/2010 01:32 AM, Aurelien Jarno wrote:
> Hi all,
>
> My impression is that few persons have interest in linux-user or
> non-KVM targets areas, at least from the development point of view.
> I personally don't care about linux-user code, though I have tried to
> merge patches in this area anyway, as otherwise they are just
> bitrotting on the mailing list.
>
> On the other hand there are quite more people at least following the
> development in these areas, as when something is broken, you are usually
> told that quite quickly.

Let's start by fixing what is broken.  Last time I checked iothread was 
broken.  If it's fixed, there was as usual no trace of the patches on 
the list...

You get kudos for posting all your patches, unlike many other 
committers, besides the work reviewing and applying ours.

Paolo

Re: [Qemu-devel] Re: Call for help in reviewing patches (!kvm & linux-user)

[Alexander Graf]

On 15.04.2010, at 02:08, Paolo Bonzini wrote:

> On 04/15/2010 01:32 AM, Aurelien Jarno wrote:
>> Hi all,
>> 
>> My impression is that few persons have interest in linux-user or
>> non-KVM targets areas, at least from the development point of view.
>> I personally don't care about linux-user code, though I have tried to
>> merge patches in this area anyway, as otherwise they are just
>> bitrotting on the mailing list.
>> 
>> On the other hand there are quite more people at least following the
>> development in these areas, as when something is broken, you are usually
>> told that quite quickly.
> 
> Let's start by fixing what is broken.  Last time I checked iothread was broken.  If it's fixed, there was as usual no trace of the patches on the list...

There was a patch from blue, posted, pinged, NACK'ed, pinged, ACK'ed my Marcelo, pushed.

Alex

[Qemu-devel] Re: Call for help in reviewing patches (!kvm & linux-user)

[Paolo Bonzini]

On 04/15/2010 02:19 AM, Alexander Graf wrote:
>>> Let's start by fixing what is broken.  Last time I checked
>>> iothread was broken.  If it's fixed, there was as usual no trace
>>> of the patches on the list...
>
> There was a patch from blue, posted, pinged, NACK'ed, pinged, ACK'ed
> my Marcelo, pushed.

Yeah, I had seen only the NACK.  Now I rebased and it's there.  Thanks,

Paolo

Re: [Qemu-devel] Call for help in reviewing patches (!kvm & linux-user)

[Riku Voipio]

On Thu, Apr 15, 2010 at 01:32:17AM +0200, Aurelien Jarno wrote:
> My impression is that few persons have interest in linux-user or 
> non-KVM targets areas, at least from the development point of view.
> I personally don't care about linux-user code, though I have tried to
> merge patches in this area anyway, as otherwise they are just 
> bitrotting on the mailing list.

I'll increase my effort on reviewing and testing linux-user patches once
I have a bit more time.

Riku