From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O3mVa-00045i-HB
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 04:39:10 -0400
Received: from [140.186.70.92] (port=54281 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O3mVZ-00045Z-63
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 04:39:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1O3mVX-0001Xj-2b
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 04:39:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55198)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1O3mVW-0001XX-PE
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 04:39:07 -0400
Message-ID: <4BCC168C.2080800@redhat.com>
Date: Mon, 19 Apr 2010 10:38:36 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] wrong behaviour of caps lock
References: <1270224121.12075.6.camel@deep-thought>
	<20100419012326.GF18876@shareable.org>
In-Reply-To: <20100419012326.GF18876@shareable.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: Benjamin Drung <bdrung@ubuntu.com>, qemu-devel@nongnu.org

Am 19.04.2010 03:23, schrieb Jamie Lokier:
> Benjamin Drung wrote:
>> -        /* SDL does not send the key up event, so we generate it */
> 
> Was the original comment just plain wrong?
> 
>> -        kbd_put_keycode(keycode);
>> -        kbd_put_keycode(keycode | 0x80);
>> +        if (ev->type == SDL_KEYUP) {
>> +            kbd_put_keycode(keycode | 0x80);
>> +        } else {
>> +            kbd_put_keycode(keycode);
>> +        }
> 
> The patch implies that SDL *does* send the key up event.
> 
> Somebody obviously thought that it doesn't, hence the comment.
> 
> So what has changed?  Is it different versions of SDL, or does the
> patch only work on some hosts / distros?

I think we already have had a discussion on this and it turned out that
Ubuntu had a "special" version of SDL which changed this behaviour. So
it is considered an Ubuntu SDL bug. Googled the old discussion for you:

http://www.mail-archive.com/qemu-devel@nongnu.org/msg25246.html

Kevin