From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O3tWc-0007qF-Fw
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 12:08:42 -0400
Received: from [140.186.70.92] (port=54777 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O3tWX-0007mS-Ja
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 12:08:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1O3tWT-00022O-78
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 12:08:37 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:62974)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1O3tWS-00021Z-PH
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 12:08:33 -0400
Message-ID: <4BCC7FDD.3000902@mail.berlios.de>
Date: Mon, 19 Apr 2010 18:07:57 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] wrong behaviour of caps lock
References: <1270224121.12075.6.camel@deep-thought>	<20100419012326.GF18876@shareable.org>
	<4BCC168C.2080800@redhat.com>
In-Reply-To: <4BCC168C.2080800@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Benjamin Drung <bdrung@ubuntu.com>, Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

Kevin Wolf schrieb:
> Am 19.04.2010 03:23, schrieb Jamie Lokier:
>> Benjamin Drung wrote:
>>> - /* SDL does not send the key up event, so we generate it */
>> Was the original comment just plain wrong?
>>
>>> - kbd_put_keycode(keycode);
>>> - kbd_put_keycode(keycode | 0x80);
>>> + if (ev->type == SDL_KEYUP) {
>>> + kbd_put_keycode(keycode | 0x80);
>>> + } else {
>>> + kbd_put_keycode(keycode);
>>> + }
>> The patch implies that SDL *does* send the key up event.
>>
>> Somebody obviously thought that it doesn't, hence the comment.
>>
>> So what has changed? Is it different versions of SDL, or does the
>> patch only work on some hosts / distros?
>
> I think we already have had a discussion on this and it turned out that
> Ubuntu had a "special" version of SDL which changed this behaviour. So
> it is considered an Ubuntu SDL bug. Googled the old discussion for you:
>
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg25246.html
>
> Kevin

My report was based on the Debian testing distribution
with libsdl components version 1.2.13-5.

So if it's a bug, both Ubuntu and Debian share it
(which is not too surprising).

And as I explained in my previous mail on this thread
QEMU's caps lock handling is buggy on any distribution.

Maybe I'll find the time to write a patch until the end
of this week.

Stefan