From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O3wVF-0003mE-L7
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 15:19:29 -0400
Received: from [140.186.70.92] (port=48250 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O3wVE-0003kd-6z
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 15:19:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1O3wVD-0005RN-4k
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 15:19:28 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:55522)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1O3wVC-0005RG-VK
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 15:19:27 -0400
Received: by pvd12 with SMTP id 12so3114385pvd.4
	for <qemu-devel@nongnu.org>; Mon, 19 Apr 2010 12:19:26 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4BCCACB0.6010104@twiddle.net>
Date: Mon, 19 Apr 2010 14:19:12 -0500
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 05/21] tcg-i386: Tidy bswap operations.
References: <cover.1271277329.git.rth@twiddle.net>
	<e36e7f72dbd7724145773f759814a3c0a184c667.1271277329.git.rth@twiddle.net>
	<20100418221302.GA26784@volta.aurel32.net>
	<4BCC611C.3020202@twiddle.net>
	<alpine.LNX.2.00.1004192004080.1477@linmac>
In-Reply-To: <alpine.LNX.2.00.1004192004080.1477@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

On 04/19/2010 11:05 AM, malc wrote:
> Apparently i'm not the only one who misinterpreted this bit of bswap
> documentation. How about:
> 
> diff --git a/tcg/README b/tcg/README
> index 68d27ff..5b39a38 100644
> --- a/tcg/README
> +++ b/tcg/README
> @@ -269,7 +269,7 @@ ext32u_i64 t0, t1
>  * bswap16_i32/i64 t0, t1
>  
>  16 bit byte swap on a 32/64 bit value. It assumes that the two/six high 
> order
> -bytes are set to zero.
> +bytes of t1 are set to zero.

Ok by me.  You should also adjust the bswap32 documentation just below.


r~