From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] raw-posix: Use pread/pwrite instead of lseek+read/write
Date: Tue, 20 Apr 2010 10:37:06 +0200 [thread overview]
Message-ID: <4BCD67B2.4050807@redhat.com> (raw)
In-Reply-To: <1271680452-24121-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 19.04.2010 14:34, schrieb Stefan Hajnoczi:
> This patch combines the lseek+read/write calls to use pread/pwrite
> instead. This will result in fewer system calls and is already used by
> AIO.
>
> Thanks to Jan Kiszka <jan.kiszka@siemens.com> for identifying excessive
> lseek and Christoph Hellwig <hch@lst.de> for confirming that this
> approach should work.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2010-04-20 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 12:34 [Qemu-devel] [PATCH 1/2] raw-posix: Use pread/pwrite instead of lseek+read/write Stefan Hajnoczi
2010-04-19 12:34 ` [Qemu-devel] [PATCH 2/2] block: Cache total_sectors to reduce bdrv_getlength calls Stefan Hajnoczi
2010-04-19 14:10 ` [Qemu-devel] " Kevin Wolf
2010-04-19 14:26 ` Stefan Hajnoczi
2010-04-19 14:31 ` Kevin Wolf
2010-04-20 8:37 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCD67B2.4050807@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).