From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4a8j-0004mp-91 for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:38:53 -0400 Received: from [140.186.70.92] (port=37402 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4a8h-0004lA-Px for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:38:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4a8b-0004Ea-4t for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:38:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42963) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4a8a-0004EL-Tr for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:38:45 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3LDciTt027001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Apr 2010 09:38:44 -0400 Message-ID: <4BCEFFC7.9080308@redhat.com> Date: Wed, 21 Apr 2010 15:38:15 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string() References: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com> <1271797792-24571-8-git-send-email-lcapitulino@redhat.com> <20100421082855.GB12843@redhat.com> In-Reply-To: <20100421082855.GB12843@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: armbru@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino Am 21.04.2010 10:28, schrieb Daniel P. Berrange: > On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: >> There are error handling functions in QEMU which print errno codes >> to the user. While it's debatable if this is good from a user >> perspective, sometimes it's the best you can do because it's what >> system calls return and this is also useful for debugging. >> >> So, we need a way to expose those codes in QMP. We can't use the >> codes themselfs because they may vary between systems. >> >> The best solution I can think of is returning the string >> representation of the name. For example, EIO becomes "EIO". >> >> This is what get_errno_string() does. >> >> Signed-off-by: Luiz Capitulino >> --- >> qemu-error.c | 25 +++++++++++++++++++++++++ >> qemu-error.h | 1 + >> 2 files changed, 26 insertions(+), 0 deletions(-) >> >> diff --git a/qemu-error.c b/qemu-error.c >> index 5a35e7c..55ce133 100644 >> --- a/qemu-error.c >> +++ b/qemu-error.c >> @@ -207,3 +207,28 @@ void error_report(const char *fmt, ...) >> va_end(ap); >> error_printf("\n"); >> } >> + >> +/* >> + * This is probably only useful for QMP >> + */ >> +const char *get_errno_string(int err) >> +{ >> + assert(err < 0); >> + >> + switch (err) { >> + case -EINVAL: >> + return "EINVAL"; >> + case -EIO: >> + return "EIO"; >> + case -ENOENT: >> + return "ENOENT"; >> + case -ENOMEDIUM: >> + return "ENOMEDIUM"; >> + case -ENOTSUP: >> + return "ENOTSUP"; >> + default: >> + return "unknown"; >> + } >> + >> + abort(); >> +} > > Wouldn't it be nicer to return strerror_r() output instead of errno > names ? I agree. And it would be more complete, too. Kevin