From: Gerd Hoffmann <kraxel@redhat.com>
To: Ian Molton <ian.molton@collabora.co.uk>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG
Date: Wed, 21 Apr 2010 15:55:30 +0200 [thread overview]
Message-ID: <4BCF03D2.5000307@redhat.com> (raw)
In-Reply-To: <4BCEF0B9.2050704@collabora.co.uk>
Hi,
> * the SIZE property patch: Msg-Id:<4BB206B9.80501@collabora.co.uk>
Fine with me.
> * the socket reconnect patch: Msg-Id:<4B18055B.1030606@collabora.co.uk>
Not sure yet.
> If we can get these patches sorted out, the only outstanding issues are
> where the EGD protocol support and rate limiting should go.
I think it makes sense to have a separate chardev backend for it, so you
can easily hook it up to either virtio-rng or something else, i.e.
define a chardev for the egd connection like this:
-chardev backend=egd,id=egd,server=$address,$rate-limit-options-here
then link it to virtio-rng ...
-device virtio-rng-pci,chardev=egd
... or virtio-serial ...
-device virtserialport,chardev=egd,name=org.qemu.egd
... or a emulated 16650 ....
-device isa-serial,chardev=egd
... depending on what you prefer and what your guest can handle.
It might make sense to have the reconnect logic in the egd chardev
backend then, thereby obsoleting the socket reconnect patch.
cheers,
Gerd
next prev parent reply other threads:[~2010-04-21 13:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 14:05 [Qemu-devel] [PATCH 0/2] VirtIO RNG Ian Molton
2010-03-30 14:12 ` [Qemu-devel] [PATCH 1/2] " Ian Molton
2010-03-30 14:13 ` [Qemu-devel] [PATCH 2/2] " Ian Molton
2010-04-01 12:17 ` Paul Brook
2010-04-01 12:30 ` Jamie Lokier
2010-04-01 14:03 ` Paul Brook
2010-04-02 10:13 ` Ian Molton
2010-04-03 15:06 ` Paul Brook
2010-04-13 14:41 ` Ian Molton
2010-04-13 15:01 ` Paul Brook
2010-04-13 15:32 ` Paul Brook
2010-04-20 15:15 ` Ian Molton
2010-04-20 16:13 ` Jamie Lokier
2010-04-20 19:52 ` Ian Molton
2010-04-20 20:11 ` Blue Swirl
2010-04-20 20:56 ` Jamie Lokier
2010-04-20 21:31 ` Ian Molton
2010-04-20 21:55 ` Jamie Lokier
2010-04-21 7:43 ` Gerd Hoffmann
2010-04-21 9:40 ` Jamie Lokier
2010-04-21 12:34 ` Ian Molton
2010-04-21 13:55 ` Gerd Hoffmann [this message]
2010-04-22 19:06 ` Ian Molton
2010-04-22 21:05 ` Jamie Lokier
2010-04-23 10:17 ` Ian Molton
2010-04-24 1:37 ` Jamie Lokier
2010-04-24 8:58 ` Ian Molton
2010-04-23 8:27 ` Gerd Hoffmann
2010-04-23 9:28 ` Ian Molton
2010-04-23 14:07 ` Gerd Hoffmann
2010-04-23 15:49 ` Ian Molton
2010-04-23 17:32 ` Jamie Lokier
2010-04-24 9:16 ` Ian Molton
2010-04-02 10:15 ` Ian Molton
2010-04-02 10:07 ` Ian Molton
2010-05-03 17:56 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCF03D2.5000307@redhat.com \
--to=kraxel@redhat.com \
--cc=ian.molton@collabora.co.uk \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).