From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4aP8-0003vV-9J
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:55:50 -0400
Received: from [140.186.70.92] (port=45171 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4aP5-0003sV-Su
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:55:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1O4aP4-0007X7-3i
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:55:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46087)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1O4aP3-0007Ws-QF
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 09:55:46 -0400
Message-ID: <4BCF03D2.5000307@redhat.com>
Date: Wed, 21 Apr 2010 15:55:30 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG
References: <4BB2053C.6000701@collabora.co.uk>	<201004031606.26893.paul@codesourcery.com>	<4BC482A6.4040504@collabora.co.uk>	<201004131632.25820.paul@codesourcery.com>	<4BCDC51F.2030205@collabora.co.uk>	<20100420161302.GA11723@shareable.org>	<4BCE061B.2030506@collabora.co.uk>	<20100420205654.GI11723@shareable.org>	<4BCE1D3B.7000306@collabora.co.uk>
	<4BCEAC99.8000206@redhat.com>
	<20100421094007.GC13114@shareable.org>
	<4BCEF0B9.2050704@collabora.co.uk>
In-Reply-To: <4BCEF0B9.2050704@collabora.co.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Molton <ian.molton@collabora.co.uk>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

   Hi,

> * the SIZE property patch:    Msg-Id:<4BB206B9.80501@collabora.co.uk>

Fine with me.

> * the socket reconnect patch: Msg-Id:<4B18055B.1030606@collabora.co.uk>

Not sure yet.

> If we can get these patches sorted out, the only outstanding issues are
> where the EGD protocol support and rate limiting should go.

I think it makes sense to have a separate chardev backend for it, so you 
can easily hook it up to either virtio-rng or something else, i.e. 
define a chardev for the egd connection like this:

-chardev backend=egd,id=egd,server=$address,$rate-limit-options-here

then link it to virtio-rng ...

-device virtio-rng-pci,chardev=egd

... or virtio-serial ...

-device virtserialport,chardev=egd,name=org.qemu.egd

... or a emulated 16650 ....

-device isa-serial,chardev=egd

... depending on what you prefer and what your guest can handle.

It might make sense to have the reconnect logic in the egd chardev 
backend then, thereby obsoleting the socket reconnect patch.

cheers,
   Gerd