From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4gJA-00063g-4U
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 16:14:04 -0400
Received: from [140.186.70.92] (port=54200 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4gJ8-0005zQ-Aa
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 16:14:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1O4gJ4-0007mM-RL
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 16:14:02 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:51131)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1O4gJ4-0007ly-Ft
	for qemu-devel@nongnu.org; Wed, 21 Apr 2010 16:13:58 -0400
Message-ID: <4BCF5C82.1030106@mail.berlios.de>
Date: Wed, 21 Apr 2010 22:13:54 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1270131607-13114-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1270131607-13114-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning
	(WIN32_LEAN_AND_MEAN redefined)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Stefan Weil schrieb:
> configure adds the macro WIN32_LEAN_AND_MEAN to
> QEMU_CFLAGS, and SDL_syswm.h defines it, too.
>
> This results in a compiler warning (redefinition of
> WIN32_LEAN_AND_MEAN in SDL_syswm.h. That warning prevents
> compilations for win32 with warning = error).
>
> Fix this by removing the definition of WIN32_LEAN_AND_MEAN
> before including SDL_syswm.h.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> sdl.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sdl.c b/sdl.c
> index 16a48e9..0334b4b 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -21,6 +21,10 @@
> * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS IN
> * THE SOFTWARE.
> */
> +
> +/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
> +#undef WIN32_LEAN_AND_MEAN
> +
> #include <SDL.h>
> #include <SDL_syswm.h>
>

No comments, no questions? The original patch still applies.

It would be nice to have this patch in QEMU master.

Regards,
Stefan