From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)
Date: Thu, 22 Apr 2010 12:11:23 +0200 [thread overview]
Message-ID: <4BD020CB.7090502@redhat.com> (raw)
In-Reply-To: <4BCF5C82.1030106@mail.berlios.de>
On 04/21/2010 10:13 PM, Stefan Weil wrote:
> Stefan Weil schrieb:
>> configure adds the macro WIN32_LEAN_AND_MEAN to
>> QEMU_CFLAGS, and SDL_syswm.h defines it, too.
>>
>> This results in a compiler warning (redefinition of
>> WIN32_LEAN_AND_MEAN in SDL_syswm.h. That warning prevents
>> compilations for win32 with warning = error).
>>
>> Fix this by removing the definition of WIN32_LEAN_AND_MEAN
>> before including SDL_syswm.h.
>>
>> +/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
>> +#undef WIN32_LEAN_AND_MEAN
>> +
>> #include<SDL.h>
>> #include<SDL_syswm.h>
>
> No comments, no questions? The original patch still applies.
Why does that conflict? If the redefinition is with the same meaning,
GCC should not conflict.
There is
#define WIN32_LEAN_AND_MEAN
in SDL_syswm.h and -DWIN32_LEAN_AND_MEAN in configure, so that should be
okay.
Paolo
next prev parent reply other threads:[~2010-04-22 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 14:20 [Qemu-devel] [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined) Stefan Weil
2010-04-21 20:13 ` [Qemu-devel] " Stefan Weil
2010-04-22 10:11 ` Paolo Bonzini [this message]
2010-04-22 15:21 ` Richard Henderson
2010-05-08 14:46 ` Stefan Weil
2010-05-10 8:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD020CB.7090502@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).