From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4tNa-0008UE-Rd
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 06:11:30 -0400
Received: from [140.186.70.92] (port=50282 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4tNZ-0008Ty-Nf
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 06:11:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1O4tNY-0003Zz-CR
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 06:11:29 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:56307)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1O4tNW-0003Zc-MD
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 06:11:28 -0400
Received: by wyb42 with SMTP id 42so805860wyb.4
	for <qemu-devel@nongnu.org>; Thu, 22 Apr 2010 03:11:25 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4BD020CB.7090502@redhat.com>
Date: Thu, 22 Apr 2010 12:11:23 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1270131607-13114-1-git-send-email-weil@mail.berlios.de>
	<4BCF5C82.1030106@mail.berlios.de>
In-Reply-To: <4BCF5C82.1030106@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning
	(WIN32_LEAN_AND_MEAN redefined)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

On 04/21/2010 10:13 PM, Stefan Weil wrote:
> Stefan Weil schrieb:
>> configure adds the macro WIN32_LEAN_AND_MEAN to
>> QEMU_CFLAGS, and SDL_syswm.h defines it, too.
>>
>> This results in a compiler warning (redefinition of
>> WIN32_LEAN_AND_MEAN in SDL_syswm.h. That warning prevents
>> compilations for win32 with warning = error).
>>
>> Fix this by removing the definition of WIN32_LEAN_AND_MEAN
>> before including SDL_syswm.h.
 >>
>> +/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
>> +#undef WIN32_LEAN_AND_MEAN
>> +
>> #include<SDL.h>
>> #include<SDL_syswm.h>
>
> No comments, no questions? The original patch still applies.

Why does that conflict?  If the redefinition is with the same meaning, 
GCC should not conflict.

There is

#define WIN32_LEAN_AND_MEAN

in SDL_syswm.h and -DWIN32_LEAN_AND_MEAN in configure, so that should be 
okay.

Paolo