From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O51nD-0005pq-E5 for qemu-devel@nongnu.org; Thu, 22 Apr 2010 15:10:31 -0400 Received: from [140.186.70.92] (port=48684 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O51nB-0005op-Ad for qemu-devel@nongnu.org; Thu, 22 Apr 2010 15:10:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O51n9-0002Cl-2c for qemu-devel@nongnu.org; Thu, 22 Apr 2010 15:10:28 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:37604) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O51n8-0002CY-Tm for qemu-devel@nongnu.org; Thu, 22 Apr 2010 15:10:27 -0400 Received: by pwi6 with SMTP id 6so5779235pwi.4 for ; Thu, 22 Apr 2010 12:10:25 -0700 (PDT) Message-ID: <4BD09F1D.1060503@codemonkey.ws> Date: Thu, 22 Apr 2010 14:10:21 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [libvirt] Libvirt debug API References: <4BBF2E93.3020508@redhat.com> <20100409142717.GA11875@redhat.com> <4BD09947.7060207@codemonkey.ws> In-Reply-To: <4BD09947.7060207@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Libvirt , Jiri Denemark , Chris Lalancette , qemu-devel@nongnu.org On 04/22/2010 01:45 PM, Anthony Liguori wrote: > Which in turn, could be embedded as: > > > myguest > ... > > Operon_G3 > 5 > AuthenticAMD > > > > With respect to injecting QMP commands directly, I think the proposed > debug API is probably reasonable. We could build a libqemu that used > that API as a transport which means that one could use libqemu and > libvirt simultaneously which is certainly a key requirement of mine. > > I think it's important that it's a dedicated monitor session though. > It shouldn't just be injecting commands within an existing QMP session > IMHO. > Another important thing to mention is that this type of conversion has two purposes. A user can inject qemu config snippets into the libvirt description, but libvirt can also inject qemu config snippets that it cannot represent via it's own XML for the user. For instance, let's say that a user adds a disk via QMP with an option that libvirt doesn't recognize. When a virsh dumpxml is executed, libvirt could display the XML using the tag instead of the tag that it normally would use. Regards, Anthony Liguori > Regards, > > Anthony Liguori