From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5IeL-0007hP-7j for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:10:29 -0400 Received: from [140.186.70.92] (port=34912 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5IeJ-0007fv-3I for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:10:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5IeH-0007R1-8B for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:10:26 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:40232) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5IeH-0007Qt-2R for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:10:25 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3ND3DSd010911 for ; Fri, 23 Apr 2010 07:03:13 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o3NDADKk108076 for ; Fri, 23 Apr 2010 07:10:16 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o3NDAAAL029426 for ; Fri, 23 Apr 2010 07:10:10 -0600 Message-ID: <4BD19C30.9020807@linux.vnet.ibm.com> Date: Fri, 23 Apr 2010 08:10:08 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1271829445-5328-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4BD0A6A5.7000106@linux.vnet.ibm.com> <4BD0ED8D.9080006@lab.ntt.co.jp> In-Reply-To: <4BD0ED8D.9080006@lab.ntt.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: ohmura.kei@lab.ntt.co.jp, kvm@vger.kernel.org, mtosatti@redhat.com, Anthony Liguori , qemu-devel@nongnu.org, yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com On 04/22/2010 07:45 PM, Yoshiaki Tamura wrote: > Anthony Liguori wrote: > >> I think it would make sense to separate out the things that are actually >> optimizations (like the dirty bitmap changes and the writev/readv >> changes) and to attempt to justify them with actual performance data. > > I agree with the separation plan. > > For dirty bitmap change, Avi and I discussed on patchset for upsream > QEMU while you were offline (Sorry, if I was wrong). Could you also > take a look? Yes, I've seen it and I don't disagree. That said, there ought to be perf data in the commit log so that down the road, the justification is understood. > http://lists.gnu.org/archive/html/qemu-devel/2010-04/msg01396.html > > Regarding writev, I agree that it should be backed with actual data, > otherwise it should be removed. We attemped to do everything that may > reduce the overhead of the transaction. > >> I'd prefer not to modify the live migration protocol ABI and it doesn't >> seem to be necessary if we're willing to add options to the -incoming >> flag. We also want to be a bit more generic with respect to IO. > > I totally agree with your approach not to change the protocol ABI. > Can we add an option to -incoming? Like, -incoming ft_mode, for example > Regarding the IO, let me reply to the next message. > >> Otherwise, the series looks very close to being mergable. > > Thank you for your comment on each patch. > > To be honest, I wasn't that confident because I'm a newbie to KVM/QEMU > and struggled for how to implement in an acceptable way. The series looks very good. I'm eager to see this functionality merged. Regards, Anthony Liguori > Thanks, > > Yoshi > >> >> Regards, >> >> Anthony Liguori >> >> >> >