From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O5ItW-00036M-A9
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:26:10 -0400
Received: from [140.186.70.92] (port=38524 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O5ItU-00035Z-OF
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:26:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1O5ItT-0001xr-4Q
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:26:08 -0400
Received: from e3.ny.us.ibm.com ([32.97.182.143]:58977)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1O5ItS-0001xk-VS
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:26:07 -0400
Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147])
	by e3.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3NDDl1f021495
	for <qemu-devel@nongnu.org>; Fri, 23 Apr 2010 09:13:47 -0400
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o3NDQ5TC2056260
	for <qemu-devel@nongnu.org>; Fri, 23 Apr 2010 09:26:05 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id
	o3NDQ5S6005119
	for <qemu-devel@nongnu.org>; Fri, 23 Apr 2010 10:26:05 -0300
Message-ID: <4BD19FEB.1040804@linux.vnet.ibm.com>
Date: Fri, 23 Apr 2010 08:26:03 -0500
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1271829445-5328-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<1271829445-5328-5-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<4BD16E30.5080502@redhat.com>
In-Reply-To: <4BD16E30.5080502@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable,
 and introduce qemu_realloc_buffer() and qemu_clear_buffer().
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: ohmura.kei@lab.ntt.co.jp, kvm@vger.kernel.org, qemu-devel@nongnu.org, mtosatti@redhat.com, Anthony Liguori <aliguori@us.ibm.com>, Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>, yoshikawa.takuya@oss.ntt.co.jp

On 04/23/2010 04:53 AM, Avi Kivity wrote:
> On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote:
>> Currently buf size is fixed at 32KB.  It would be useful if it could
>> be flexible.
>>
>
> Why is this needed?  The real buffering is in the kernel anyways; this 
> is only used to reduce the number of write() syscalls.

With vmstate, we really shouldn't need to do this magic anymore as an 
optimization.

Regards,

Anthony Liguori