qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails
Date: Fri, 23 Apr 2010 15:28:32 +0200	[thread overview]
Message-ID: <4BD1A080.2020202@redhat.com> (raw)
In-Reply-To: <4BD19816.4050506@msgid.tls.msk.ru>

Am 23.04.2010 14:52, schrieb Michael Tokarev:
> Kevin Wolf wrote:
>> Am 22.04.2010 11:52, schrieb Markus Armbruster:
>>> Michael Tokarev <mjt@tls.msk.ru> writes:
>>>
>>>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
>>>> (with fprintf) something like this:
>>>>
> []
>>>>      TFR(fd = open("/dev/net/tun", O_RDWR));
>>>>      if (fd < 0) {
>>>> -        fprintf(stderr, "warning: could not open /dev/net/tun: no virtual network emulation\n");
>>>> +        qemu_error("could not open /dev/net/tun: %m\n");
>>>>          return -1;
>>
>> I'm not sure where this %m is defined exactly (Linux specific? Maybe
>> BSDs, too?), but it doesn't seem to work with mingw.
> 
> The file being patched is tap-linux.c.
> I noted this in my first email.

Sorry, I missed that. You're right, of course.

Kevin

  reply	other threads:[~2010-04-23 13:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22  9:28 [Qemu-devel] [PATCH] give some useful error messages when tap open fails Michael Tokarev
2010-04-22  9:52 ` Markus Armbruster
2010-04-23 12:08   ` Michael Tokarev
2010-04-23 13:44     ` Markus Armbruster
2010-04-23 12:46   ` Kevin Wolf
2010-04-23 12:52     ` Michael Tokarev
2010-04-23 13:28       ` Kevin Wolf [this message]
2010-04-26 18:41         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD1A080.2020202@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).