From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5IzC-0004sv-Th for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:32:02 -0400 Received: from [140.186.70.92] (port=39118 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5Iz7-0004MR-P6 for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:32:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5IwI-0002Tz-AF for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:29:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54131) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5IwI-0002Tm-16 for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:29:02 -0400 Message-ID: <4BD1A080.2020202@redhat.com> Date: Fri, 23 Apr 2010 15:28:32 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails References: <20100422092826.EF03612B5C@gandalf.tls.msk.ru> <4BD196BB.6050603@redhat.com> <4BD19816.4050506@msgid.tls.msk.ru> In-Reply-To: <4BD19816.4050506@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Markus Armbruster , qemu-devel@nongnu.org Am 23.04.2010 14:52, schrieb Michael Tokarev: > Kevin Wolf wrote: >> Am 22.04.2010 11:52, schrieb Markus Armbruster: >>> Michael Tokarev writes: >>> >>>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >>>> (with fprintf) something like this: >>>> > [] >>>> TFR(fd = open("/dev/net/tun", O_RDWR)); >>>> if (fd < 0) { >>>> - fprintf(stderr, "warning: could not open /dev/net/tun: no virtual network emulation\n"); >>>> + qemu_error("could not open /dev/net/tun: %m\n"); >>>> return -1; >> >> I'm not sure where this %m is defined exactly (Linux specific? Maybe >> BSDs, too?), but it doesn't seem to work with mingw. > > The file being patched is tap-linux.c. > I noted this in my first email. Sorry, I missed that. You're right, of course. Kevin