From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots
Date: Sun, 25 Apr 2010 15:33:03 +0300 [thread overview]
Message-ID: <4BD4367F.5060307@redhat.com> (raw)
In-Reply-To: <4BD29F22.8020806@web.de>
On 04/24/2010 10:34 AM, Jan Kiszka wrote:
> Marcelo Tosatti wrote:
>
>> Otherwise there is no way to differentiate between global and slot
>> specific logging, so for example
>>
>> vga dirty log start
>> migration start
>> migration fail
>>
>> Disables dirty logging for the vga slot.
>>
> This is not true (unless there is a bug): Migration logging is tracked
> via KVMState::migration_log and vga logging via KVMSlot::flags. Both are
> merged in kvm_set_user_memory_region. Thus no such change is required
> for upstream.
>
It's still a good idea. The current API assumes that there will be only
one slot-based client (or that multiple clients will keep the refcount
themselves).
After the bytemap -> multiple bitmaps conversion this can be extended to
each client getting its own bitmap (and therefore, s/refcount/list of
bitmaps/ and s/!refcount/list_empty()/).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-25 12:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 17:04 [Qemu-devel] [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code Marcelo Tosatti
2010-04-23 17:04 ` [Qemu-devel] [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop Marcelo Tosatti
2010-04-23 17:04 ` [Qemu-devel] [uq/master patch 2/5] kvm: add logging count to slots Marcelo Tosatti
2010-04-24 7:34 ` [Qemu-devel] " Jan Kiszka
2010-04-25 12:33 ` Avi Kivity [this message]
2010-04-25 13:57 ` Jan Kiszka
2010-04-25 14:17 ` Avi Kivity
2010-04-25 14:29 ` Jan Kiszka
2010-04-25 14:41 ` Avi Kivity
2010-04-25 14:51 ` Jan Kiszka
2010-04-25 14:58 ` Avi Kivity
2010-04-25 15:07 ` Jan Kiszka
2010-04-25 15:22 ` Avi Kivity
2010-04-25 16:42 ` Jan Kiszka
2010-04-26 5:37 ` Avi Kivity
2010-04-26 13:47 ` Marcelo Tosatti
2010-04-23 17:04 ` [Qemu-devel] [uq/master patch 3/5] introduce leul_to_cpu Marcelo Tosatti
2010-04-23 17:04 ` [Qemu-devel] [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning Marcelo Tosatti
2010-04-23 17:04 ` [Qemu-devel] [uq/master patch 5/5] introduce qemu_ram_map Marcelo Tosatti
2010-04-25 12:33 ` [Qemu-devel] Re: [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD4367F.5060307@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).