From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O611J-0006pU-In
	for qemu-devel@nongnu.org; Sun, 25 Apr 2010 08:33:09 -0400
Received: from [140.186.70.92] (port=40911 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O611I-0006oF-6T
	for qemu-devel@nongnu.org; Sun, 25 Apr 2010 08:33:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O611G-0006Tl-RJ
	for qemu-devel@nongnu.org; Sun, 25 Apr 2010 08:33:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27718)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O611G-0006Td-IG
	for qemu-devel@nongnu.org; Sun, 25 Apr 2010 08:33:06 -0400
Message-ID: <4BD4367F.5060307@redhat.com>
Date: Sun, 25 Apr 2010 15:33:03 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20100423170410.914857113@amt.cnet>
	<20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de>
In-Reply-To: <4BD29F22.8020806@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to
	slots
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 04/24/2010 10:34 AM, Jan Kiszka wrote:
> Marcelo Tosatti wrote:
>    
>> Otherwise there is no way to differentiate between global and slot
>> specific logging, so for example
>>
>> vga dirty log start
>> migration start
>> migration fail
>>
>> Disables dirty logging for the vga slot.
>>      
> This is not true (unless there is a bug): Migration logging is tracked
> via KVMState::migration_log and vga logging via KVMSlot::flags. Both are
> merged in kvm_set_user_memory_region. Thus no such change is required
> for upstream.
>    

It's still a good idea.  The current API assumes that there will be only 
one slot-based client (or that multiple clients will keep the refcount 
themselves).

After the bytemap -> multiple bitmaps conversion this can be extended to 
each client getting its own bitmap (and therefore, s/refcount/list of 
bitmaps/ and s/!refcount/list_empty()/).

-- 
error compiling committee.c: too many arguments to function