From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O62LE-0004bq-6V for qemu-devel@nongnu.org; Sun, 25 Apr 2010 09:57:48 -0400 Received: from [140.186.70.92] (port=58403 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O62L9-0004b1-F5 for qemu-devel@nongnu.org; Sun, 25 Apr 2010 09:57:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O62L7-0001cQ-V3 for qemu-devel@nongnu.org; Sun, 25 Apr 2010 09:57:43 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:60765) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O62L7-0001c8-JC for qemu-devel@nongnu.org; Sun, 25 Apr 2010 09:57:41 -0400 Message-ID: <4BD44A4D.4060008@web.de> Date: Sun, 25 Apr 2010 15:57:33 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> In-Reply-To: <4BD4367F.5060307@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig64D5DECCB8CA47ADB288B441" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig64D5DECCB8CA47ADB288B441 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 04/24/2010 10:34 AM, Jan Kiszka wrote: >> Marcelo Tosatti wrote: >> =20 >>> Otherwise there is no way to differentiate between global and slot >>> specific logging, so for example >>> >>> vga dirty log start >>> migration start >>> migration fail >>> >>> Disables dirty logging for the vga slot. >>> =20 >> This is not true (unless there is a bug): Migration logging is tracked= >> via KVMState::migration_log and vga logging via KVMSlot::flags. Both a= re >> merged in kvm_set_user_memory_region. Thus no such change is required >> for upstream. >> =20 >=20 > It's still a good idea. The current API assumes that there will be onl= y > one slot-based client (or that multiple clients will keep the refcount > themselves). >=20 > After the bytemap -> multiple bitmaps conversion this can be extended t= o > each client getting its own bitmap (and therefore, s/refcount/list of > bitmaps/ and s/!refcount/list_empty()/). >=20 No concerns if - there is an existing use case for multiple clients, at least in qemu-kvm - the logging API is consistently converted, not just extended (IOW, migration_log is converted to logging_count) - someone signs he checked that current use of start/stop in qemu is completely symmetrical (I think to remember this used to be not the case, but I might be wrong) Jan --------------enig64D5DECCB8CA47ADB288B441 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvUSlIACgkQitSsb3rl5xQQTgCeJtCyLBMtjhvF6AYygd8+TtrT 6NUAoMIV74NGN5Vh141bHH4R7wOPu0mz =rRu2 -----END PGP SIGNATURE----- --------------enig64D5DECCB8CA47ADB288B441--