From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6319-00072W-Ls for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:41:07 -0400 Received: from [140.186.70.92] (port=39250 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6318-00071u-71 for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6316-0008Ps-Cf for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:41:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33050) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6316-0008PM-3c for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:41:04 -0400 Message-ID: <4BD4547C.5060907@redhat.com> Date: Sun, 25 Apr 2010 17:41:00 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de> In-Reply-To: <4BD451D9.4090209@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 04/25/2010 05:29 PM, Jan Kiszka wrote: > >> There isn't. But I don't like hidden breakage. >> > It's (so far) an unproblematic API property we can document. I don't > like changing APIs just for "there might be the case that...". > I guess it's one of those agree to disagree things. I dislike known broken APIs even if their none of their users are affected. >>> - the logging API is consistently converted, not just extended >>> (IOW, migration_log is converted to logging_count) >>> >>> >> migration_log needs to remain global, since we want hotplug memory to >> autostart logging. >> > Can't follow yet, what will be the usage pattern of > kvm_set_migration_log? Or would the hotplug code require a separate > interface? Is it already the multi-client use case I'm looking for? > kvm_set_migration_log() means, start logging now for all current and future memory, until disabled. It could be implemented in terms of kvm_log_start() (which would provide a multi-client use case), but it isn't now. I guess it is a logical example of how two clients can exist, even though they don't step on each others toes in practice since their enable flags are kept separate by the implementation. -- error compiling committee.c: too many arguments to function