From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O63Ah-0001mA-7L for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:50:59 -0400 Received: from [140.186.70.92] (port=40945 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O63Ag-0001lY-77 for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O63Ae-0001ho-Rv for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:50:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35303) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O63Ae-0001hi-J9 for qemu-devel@nongnu.org; Sun, 25 Apr 2010 10:50:56 -0400 Message-ID: <4BD456CC.2020306@redhat.com> Date: Sun, 25 Apr 2010 17:50:52 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [libvirt] Libvirt debug API References: <4BBF2E93.3020508@redhat.com> <20100409142717.GA11875@redhat.com> <4BD09947.7060207@codemonkey.ws> <20100423102831.GA17700@redhat.com> <4BD1A361.6040702@codemonkey.ws> <20100423142158.GD17700@redhat.com> <4BD1E80C.30402@codemonkey.ws> In-Reply-To: <4BD1E80C.30402@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Libvirt , Jiri Denemark , Chris Lalancette , qemu-devel@nongnu.org On 04/23/2010 09:33 PM, Anthony Liguori wrote: >> This is a different ambiguity, about the semantic results of the >> commands, >> where as I'm refering to the execution order. If I look at a libvirt log >> file and see a set of JSON commands logged, I want to know that this >> ordering >> from the logs, was indeed the same as order in which qemu processed >> them. If >> you have two separate monitor connection you can't be sure of the >> order of >> execution. It is key for our bug troubleshooting that given a libvirt >> log >> file, we can replay the JSON commands again and get the same results. >> Two >> monitor connections is just increasing complexity of code without any >> tangible benefit. > > I think you're assuming direct access to the second monitor? I'm not > suggesting that. I'm suggesting that libvirt is still the one > submitting commands to the second monitor and that it submits those > commands in lock step. > What about protocol extensions? For instance, pretend libvirt doesn't support async messages, what would it do when it receives one from the user's monitor? -- error compiling committee.c: too many arguments to function