From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6H0s-0006LH-MI
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 01:37:46 -0400
Received: from [140.186.70.92] (port=59422 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6H0q-0006Kv-6P
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 01:37:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O6H0o-0005kz-VJ
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 01:37:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30425)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O6H0o-0005kp-Nr
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 01:37:42 -0400
Message-ID: <4BD526A2.60703@redhat.com>
Date: Mon, 26 Apr 2010 08:37:38 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20100423170410.914857113@amt.cnet>
	<20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de>
	<4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de>
	<4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de>
	<4BD4547C.5060907@redhat.com> <4BD45709.9070705@web.de>
	<4BD458AD.9020500@redhat.com> <4BD45A96.3080800@web.de>
	<4BD45E32.1070406@redhat.com> <4BD470E3.9050803@web.de>
In-Reply-To: <4BD470E3.9050803@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to
	slots
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 04/25/2010 07:42 PM, Jan Kiszka wrote:
>
>> Unrelated:
>>
>>          cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000);
>>          cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000);
>>
>> Will this sync to the right place (whatever those windows alias to)?
>>
>>      
> It should. Or where do your worries come from?
>
>    

I was worried the bitmap was indexed by physical addresses, but now I 
remember it is indexed by ram addresses, so it all works out.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.