From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6TFX-0000g7-Kt
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:41:43 -0400
Received: from [140.186.70.92] (port=56362 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6TFW-0000eT-5c
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:41:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6TFR-0005yL-3w
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:41:41 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:51730)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6TFQ-0005y2-WC
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:41:37 -0400
Received: by vws3 with SMTP id 3so37323vws.4
	for <qemu-devel@nongnu.org>; Mon, 26 Apr 2010 11:41:36 -0700 (PDT)
Message-ID: <4BD5DE50.20204@codemonkey.ws>
Date: Mon, 26 Apr 2010 13:41:20 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] give some useful error messages when tap
	open fails
References: <20100422092826.EF03612B5C@gandalf.tls.msk.ru>	<m3d3xrlsqb.fsf@blackfin.pond.sub.org>	<4BD196BB.6050603@redhat.com>
	<4BD19816.4050506@msgid.tls.msk.ru> <4BD1A080.2020202@redhat.com>
In-Reply-To: <4BD1A080.2020202@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 04/23/2010 08:28 AM, Kevin Wolf wrote:
> Am 23.04.2010 14:52, schrieb Michael Tokarev:
>    
>> Kevin Wolf wrote:
>>      
>>> Am 22.04.2010 11:52, schrieb Markus Armbruster:
>>>        
>>>> Michael Tokarev<mjt@tls.msk.ru>  writes:
>>>>
>>>>          
>>>>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
>>>>> (with fprintf) something like this:
>>>>>
>>>>>            
>> []
>>      
>>>>>       TFR(fd = open("/dev/net/tun", O_RDWR));
>>>>>       if (fd<  0) {
>>>>> -        fprintf(stderr, "warning: could not open /dev/net/tun: no virtual network emulation\n");
>>>>> +        qemu_error("could not open /dev/net/tun: %m\n");
>>>>>           return -1;
>>>>>            
>>> I'm not sure where this %m is defined exactly (Linux specific? Maybe
>>> BSDs, too?), but it doesn't seem to work with mingw.
>>>        
>> The file being patched is tap-linux.c.
>> I noted this in my first email.
>>      
> Sorry, I missed that. You're right, of course.
>    

But from a consistency perspective, "%s", strerror(errno) would be nicer 
even if it's technically okay.

Regards,

Anthony Liguori

> Kevin
>
>
>
>