From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6TS9-0007OS-8C
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:54:45 -0400
Received: from [140.186.70.92] (port=55422 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6TS7-0007MS-71
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:54:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6TS5-0008UN-Pk
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:54:43 -0400
Received: from mail-px0-f173.google.com ([209.85.212.173]:53486)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6TS5-0008UB-Bc
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:54:41 -0400
Received: by pxi19 with SMTP id 19so1669074pxi.4
	for <qemu-devel@nongnu.org>; Mon, 26 Apr 2010 11:54:40 -0700 (PDT)
Message-ID: <4BD5E16B.5010308@codemonkey.ws>
Date: Mon, 26 Apr 2010 13:54:35 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1272304746.git.mtosatti@redhat.com>
	<2e085c19aac78e6c4335eac4fffeb5cfca4bbb26.1272304746.git.mtosatti@redhat.com>
	<4BD5DB12.6020406@codemonkey.ws> <20100426184928.GF21425@amt.cnet>
In-Reply-To: <20100426184928.GF21425@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Cam Macdonell <cam@cs.ualberta.ca>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 04/26/2010 01:49 PM, Marcelo Tosatti wrote:
> On Mon, Apr 26, 2010 at 01:27:30PM -0500, Anthony Liguori wrote:
>    
>> On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
>>      
>>> Which allows drivers to register an mmaped region into ram block mappings.
>>> To be used by device assignment driver.
>>>        
>> This doesn't make much sense to me.
>>
>> Do you use this like:
>>
>> qemu_ram_map(64k, ptr);
>> assert(qemu_ram_alloc(64k) == ptr);
>>      
> No. hw/device-assignment.c in qemu-kvm mmaps
> /sys/bus/pci/devices/x:y:z/resourcen (the PCI devices memory regions) to
> the guest.
>    

I understand, but how do you use qemu_ram_map() to actually map that 
memory to a given PCI device resource?  I assume you rely on it getting 
put on the front of the list so that the next qemu_ram_alloc() will be 
at that location.

Regards,

Anthony Liguori

>> If so, I think this is not the best API.  I'd rather see
>> qemu_ram_map() register a symbolic name for the region and for there
>> to be a qemu_ram_alloc() variant that allocated by name.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>