From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6frW-0004Hx-Vk
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 04:09:47 -0400
Received: from [140.186.70.92] (port=40844 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6frU-0004Hf-Sx
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 04:09:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1O6frT-00058p-Cs
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 04:09:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5435)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1O6frT-00058I-5H
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 04:09:43 -0400
Message-ID: <4BD69BBA.1070307@redhat.com>
Date: Tue, 27 Apr 2010 10:09:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1272318743-17113-1-git-send-email-froydnj@codesourcery.com>
In-Reply-To: <1272318743-17113-1-git-send-email-froydnj@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] fix whitespace bogon in some versions of
	make
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 04/26/2010 11:52 PM, Nathan Froyd wrote:
> With three different make binaries I have available, configuring a
> pristine QEMU tree and attempting to make gives the cryptic:
>
> Makefile:27: *** missing separator.  Stop.
>
> This patch fixes it (presumably because it makes the output of
> `set-vpath' be an empty string, rather than a bit of whitespace), but I
> don't understand why this hasn't been a problem for other folks before.
>
> Signed-off-by: Nathan Froyd<froydnj@codesourcery.com>
> ---
>   rules.mak |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 5941b73..7e10432 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -40,7 +40,7 @@ cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
>                 >/dev/null 2>&1&&  echo OK), $2, $3)
>
>   VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
> -set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES), $(eval vpath $(PATTERN) $1)))
> +set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
>
>   # Generate timestamp files for .h include files

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo