qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dor Laor <dlaor@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Chris Wright <chrisw@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: KVM call agenda for Apr 27
Date: Tue, 27 Apr 2010 12:08:37 +0300	[thread overview]
Message-ID: <4BD6A995.2010006@redhat.com> (raw)
In-Reply-To: <4BD6A6BA.1090600@redhat.com>

On 04/27/2010 11:56 AM, Avi Kivity wrote:
> On 04/27/2010 11:48 AM, Dor Laor wrote:
>>> Here's another option: an nbd-like protocol that remotes all BlockDriver
>>> operations except read and write over a unix domain socket. The open
>>> operation returns an fd (SCM_RIGHTS strikes again) that is used for read
>>> and write. This can be used to implement snapshots over LVM, for
>>> example.
>>>
>>
>>
>> Why w/o read/writes?
>
> To avoid the copying.

Of course, just pass the offset+len on read/write too

>
>> the watermark code needs them too (as info, not the actual buffer).
>
> Yeah. It works for lvm snapshots, not for watermarks.
>
>>
>> IMHO the whole thing is way over engineered:
>> a) Having another channel into qemu is complicating management
>> software. Isn't the monitor should be the channel? Otherwise we'll
>> need to create another QMP (or nbd like Avi suggest) for these
>> actions. It's extra work for mgmt and they will have hard time to
>> understand events interleaving of the various channels
>
> block layer plugins allow intercepting all interesting block layer
> events, not just write-past-a-watermark, and allow actions based on
> those events. It's a more general solution.

No problem there, as long as we do try to use the single existing QMP 
with the plugins. Otherwise we'll create QMP2 for the block events in a 
year from now.

>
>> b) How the plugins are defined? Is it scripts? Binaries? Do they open
>> their own sockets?
>
> Shared objects.
>
>

  reply	other threads:[~2010-04-27  9:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 17:26 [Qemu-devel] KVM call agenda for Apr 27 Chris Wright
2010-04-26 17:51 ` [Qemu-devel] " Anthony Liguori
2010-04-26 22:12   ` Chris Wright
2010-04-26 22:36     ` Anthony Liguori
2010-04-27  8:14       ` Avi Kivity
2010-04-27  8:48         ` Dor Laor
2010-04-27  8:56           ` Avi Kivity
2010-04-27  9:08             ` Dor Laor [this message]
2010-04-27  9:22               ` Avi Kivity
2010-04-27  9:32                 ` Dor Laor
2010-04-27  9:41                   ` Kevin Wolf
2010-04-27 13:15                     ` Anthony Liguori
2010-04-27  9:16             ` Kevin Wolf
2010-04-27  9:28               ` Avi Kivity
2010-04-27 13:03         ` Anthony Liguori
2010-04-27 13:08           ` Avi Kivity
2010-04-27 13:11           ` Daniel P. Berrange
2010-04-27 13:15             ` Gleb Natapov
2010-04-27 13:38               ` Daniel P. Berrange
2010-04-27 14:10                 ` Gleb Natapov
2010-04-27  8:53       ` Kevin Wolf
2010-04-27 13:10         ` Anthony Liguori
2010-04-27 13:18           ` Kevin Wolf
2010-04-27 13:21             ` Anthony Liguori
2010-04-27 13:42               ` Kevin Wolf
2010-04-27 13:48                 ` Anthony Liguori
2010-04-27 13:58                   ` Kevin Wolf
2010-04-27 14:01                     ` Anthony Liguori
2010-04-27 11:11       ` Gleb Natapov
2010-04-27 13:00         ` Anthony Liguori
2010-04-27 13:05           ` Gleb Natapov
2010-04-27 13:19             ` Anthony Liguori
2010-04-27 13:29               ` Gleb Natapov
2010-04-27  1:15   ` Luiz Capitulino
2010-04-27  3:39     ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD6A995.2010006@redhat.com \
    --to=dlaor@redhat.com \
    --cc=avi@redhat.com \
    --cc=chrisw@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).