From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'
Date: Tue, 27 Apr 2010 13:52:29 +0200 [thread overview]
Message-ID: <4BD6CFFD.6070308@redhat.com> (raw)
In-Reply-To: <20100426164448.679a4d19@redhat.com>
On 04/26/2010 09:44 PM, Luiz Capitulino wrote:
> + qemu_system_exit_request();
Untested suggestion: why add qemu_system_exit_request, exit_requested,
and a hook in the main loop? You can do instead
no_shutdown = 0;
qemu_system_shutdown_request();
which will actually call quit_timers() and net_cleanup() properly unlike
a blind exit(0).
Alternatively, just give an error when "quit"-ting from QMP and keep the
current behavior for non-QMP. This way you do not provide two ways to
do the same thing. People will have to avoid -no-shutdown (I don't see
how it is useful from QMP) and they will be able to use the "shutdown"
monitor command.
Paolo
next prev parent reply other threads:[~2010-04-27 11:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 15:47 [Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 1/9] QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 2/9] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 3/9] QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 4/9] QMP: Check "arguments" member's type Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit' Luiz Capitulino
2010-04-26 17:49 ` Anthony Liguori
2010-04-26 18:22 ` Luiz Capitulino
2010-04-26 18:25 ` Anthony Liguori
2010-04-26 18:53 ` Luiz Capitulino
2010-04-26 19:00 ` Anthony Liguori
2010-04-26 19:10 ` [Qemu-devel] " Jan Kiszka
2010-04-26 19:13 ` Anthony Liguori
2010-04-26 19:44 ` Luiz Capitulino
2010-04-27 11:52 ` Paolo Bonzini [this message]
2010-04-27 13:20 ` Luiz Capitulino
2010-04-27 13:52 ` Paolo Bonzini
2010-04-26 15:47 ` [Qemu-devel] [PATCH 6/9] monitor: Cleanup ID assignment for compat switch Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 7/9] monitor: Reorder intialization to drop initial mux focus Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 8/9] chardev: Document mux option Luiz Capitulino
2010-04-26 15:47 ` [Qemu-devel] [PATCH 9/9] stash away SCM_RIGHTS fd until a getfd command arrives Luiz Capitulino
2010-04-26 21:32 ` [Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD6CFFD.6070308@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@web.de \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).