From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6oic-0007zS-4Y
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:37:10 -0400
Received: from [140.186.70.92] (port=46688 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6oia-0007zI-QI
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:37:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6oiZ-0004jy-As
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:37:08 -0400
Received: from mail-pz0-f204.google.com ([209.85.222.204]:42347)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6oiZ-0004jk-3m
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:37:07 -0400
Received: by pzk42 with SMTP id 42so9098491pzk.4
	for <qemu-devel@nongnu.org>; Tue, 27 Apr 2010 10:37:05 -0700 (PDT)
Message-ID: <4BD720BC.3090503@codemonkey.ws>
Date: Tue, 27 Apr 2010 12:37:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-2-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-3-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-4-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-5-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-6-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1272371652-23087-6-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control
 messages to notify guest of new ports
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On 04/27/2010 07:33 AM, Amit Shah wrote:
> Allow the port 'id's to be set by a user on the command line. This is
> needed by management apps that will want a stable port numbering scheme
> for hot-plug/unplug and migration.
>
> Since the port numbers are shared with the guest (to identify ports in
> control messages), we just send a control message to the guest
> indicating addition of new ports (hot-plug) or notifying the guest of
> the available ports when the guest sends us a DEVICE_READY control
> message.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

If you're introducing a new message type, don't you need to negotiate 
that feature with the guest?

Regards,

Anthony Liguori