From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6omv-0000pW-1J
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:41:37 -0400
Received: from [140.186.70.92] (port=54044 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6omt-0000pJ-Og
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:41:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6oms-0005Po-EF
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:41:35 -0400
Received: from mail-qy0-f188.google.com ([209.85.221.188]:53400)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O6oms-0005Pk-AD
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 13:41:34 -0400
Received: by qyk26 with SMTP id 26so7333209qyk.19
	for <qemu-devel@nongnu.org>; Tue, 27 Apr 2010 10:41:33 -0700 (PDT)
Message-ID: <4BD721C7.8010102@codemonkey.ws>
Date: Tue, 27 Apr 2010 12:41:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-4-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-5-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-6-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-7-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-8-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-9-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-10-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-11-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-12-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-13-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-14-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-15-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-16-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-17-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-18-git-send-email-amit.shah@redhat.com>
	<1272371652-23087-19-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1272371652-23087-19-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up
 iothread upon guest read notification
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On 04/27/2010 07:34 AM, Amit Shah wrote:
> From: Marcelo Tosatti<mtosatti@redhat.com>
>
> Wake up iothread when buffers are consumed.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

What's the race here?  This looks very odd to me.

Regards,

Anthony Liguori

> ---
>   hw/virtio-serial-bus.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 97694d5..ee868e9 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -417,6 +417,7 @@ static void handle_output(VirtIODevice *vdev, VirtQueue *vq)
>
>   static void handle_input(VirtIODevice *vdev, VirtQueue *vq)
>   {
> +    qemu_notify_event();
>   }
>
>   static uint32_t get_features(VirtIODevice *vdev, uint32_t features)
>