From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v3] qcow2: Implement bdrv_truncate() for growing images
Date: Wed, 28 Apr 2010 14:38:32 +0200 [thread overview]
Message-ID: <4BD82C48.1030406@redhat.com> (raw)
In-Reply-To: <1272450971-8289-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 28.04.2010 12:36, schrieb Stefan Hajnoczi:
> This patch adds the ability to grow qcow2 images in-place using
> bdrv_truncate(). This enables qemu-img resize command support for
> qcow2.
>
> Snapshots are not supported and bdrv_truncate() will return -ENOTSUP.
> The notion of resizing an image with snapshots could lead to confusion:
> users may expect snapshots to remain unchanged, but this is not possible
> with the current qcow2 on-disk format where the header.size field is
> global instead of per-snapshot. Others may expect snapshots to change
> size along with the current image data. I think it is safest to not
> support snapshots and perhaps add behavior later if there is a
> consensus.
>
> Backing images continue to work. If the image is now larger than its
> backing image, zeroes are read when accessing beyond the end of the
> backing image.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2010-04-28 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 10:36 [Qemu-devel] [PATCH v3] qcow2: Implement bdrv_truncate() for growing images Stefan Hajnoczi
2010-04-28 12:38 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD82C48.1030406@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).