From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O76Xk-0003zK-CC
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 08:39:08 -0400
Received: from [140.186.70.92] (port=48876 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O76Xe-0003xJ-S1
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 08:39:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1O76Xd-0002Cg-Es
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 08:39:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44836)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1O76Xd-0002CT-6K
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 08:39:01 -0400
Message-ID: <4BD82C48.1030406@redhat.com>
Date: Wed, 28 Apr 2010 14:38:32 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1272450971-8289-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1272450971-8289-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3] qcow2: Implement bdrv_truncate() for
	growing images
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

Am 28.04.2010 12:36, schrieb Stefan Hajnoczi:
> This patch adds the ability to grow qcow2 images in-place using
> bdrv_truncate().  This enables qemu-img resize command support for
> qcow2.
> 
> Snapshots are not supported and bdrv_truncate() will return -ENOTSUP.
> The notion of resizing an image with snapshots could lead to confusion:
> users may expect snapshots to remain unchanged, but this is not possible
> with the current qcow2 on-disk format where the header.size field is
> global instead of per-snapshot.  Others may expect snapshots to change
> size along with the current image data.  I think it is safest to not
> support snapshots and perhaps add behavior later if there is a
> consensus.
> 
> Backing images continue to work.  If the image is now larger than its
> backing image, zeroes are read when accessing beyond the end of the
> backing image.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

Kevin