From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O77Hj-0002qN-EO for qemu-devel@nongnu.org; Wed, 28 Apr 2010 09:26:39 -0400 Received: from [140.186.70.92] (port=40271 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O77Hh-0002pl-OI for qemu-devel@nongnu.org; Wed, 28 Apr 2010 09:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O77Hc-0002Z8-FZ for qemu-devel@nongnu.org; Wed, 28 Apr 2010 09:26:37 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:32995) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O77Hc-0002T5-AB for qemu-devel@nongnu.org; Wed, 28 Apr 2010 09:26:32 -0400 Received: by mail-pv0-f173.google.com with SMTP id 11so1106711pvh.4 for ; Wed, 28 Apr 2010 06:26:32 -0700 (PDT) Message-ID: <4BD83781.80907@codemonkey.ws> Date: Wed, 28 Apr 2010 08:26:25 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com> <1272371652-23087-2-git-send-email-amit.shah@redhat.com> <1272371652-23087-3-git-send-email-amit.shah@redhat.com> <1272371652-23087-4-git-send-email-amit.shah@redhat.com> <1272371652-23087-5-git-send-email-amit.shah@redhat.com> <1272371652-23087-6-git-send-email-amit.shah@redhat.com> <4BD720BC.3090503@codemonkey.ws> <20100428042749.GA27314@amit-x200.redhat.com> In-Reply-To: <20100428042749.GA27314@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list , Juan Quintela On 04/27/2010 11:27 PM, Amit Shah wrote: > On (Tue) Apr 27 2010 [12:37:00], Anthony Liguori wrote: > >> On 04/27/2010 07:33 AM, Amit Shah wrote: >> >>> Allow the port 'id's to be set by a user on the command line. This is >>> needed by management apps that will want a stable port numbering scheme >>> for hot-plug/unplug and migration. >>> >>> Since the port numbers are shared with the guest (to identify ports in >>> control messages), we just send a control message to the guest >>> indicating addition of new ports (hot-plug) or notifying the guest of >>> the available ports when the guest sends us a DEVICE_READY control >>> message. >>> >>> Signed-off-by: Amit Shah >>> >>> >> If you're introducing a new message type, don't you need to negotiate >> that feature with the guest? >> > Since we didn't have any kernel or qemu released with the older ABI, > changing the numbers isn't a bad thing (we disabled multiport support > for 2.6.34 because of this). > Ok. Regards, Anthony Liguori > Amit >