From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O79Nh-0001CZ-Vs
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 11:40:58 -0400
Received: from [140.186.70.92] (port=37643 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O79Ng-0001CR-KW
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 11:40:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O79Nf-0001a7-Bw
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 11:40:56 -0400
Received: from mail-qy0-f188.google.com ([209.85.221.188]:43949)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O79Nf-0001Zt-6W
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 11:40:55 -0400
Received: by qyk26 with SMTP id 26so8975596qyk.19
	for <qemu-devel@nongnu.org>; Wed, 28 Apr 2010 08:40:54 -0700 (PDT)
Message-ID: <4BD8569A.1030205@codemonkey.ws>
Date: Wed, 28 Apr 2010 10:39:06 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1272304746.git.mtosatti@redhat.com>
	<1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com>
In-Reply-To: <1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit
	kvm_arch_reset_vcpu from kvm_init_vcpu
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
> This is now done via the initialization's qemu_system_reset call.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   kvm-all.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 9c8aa7d..eabb097 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env)
>       ret = kvm_arch_init_vcpu(env);
>       if (ret == 0) {
>           qemu_register_reset(kvm_reset_vcpu, env);
> -        kvm_arch_reset_vcpu(env);
>       }
>   err:
>       return ret;
>    

This breaks -enable-kvm in upstream qemu.  No progress is ever made in 
the guest.

Regards,

Anthony Liguori