qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: ericvh@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
	Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [Qemu-devel] [PATCH -V5 01/21] virtio-9p: Create a commandline option -fsdev
Date: Wed, 28 Apr 2010 14:53:44 -0500	[thread overview]
Message-ID: <4BD89248.3010901@linux.vnet.ibm.com> (raw)
In-Reply-To: <1271340671-19558-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On 04/15/2010 09:10 AM, Aneesh Kumar K.V wrote:
> From: Gautham R Shenoy<ego@in.ibm.com>
>
> This patch creates a new command line option named -fsdev to hold any file
> system specific information.
>
> The option will currently hold the following attributes:
> -fsdev fstype id=id,path=path_to_share
> where
> fstype: Type of the file system.
> id:     Identifier used to refer to this fsdev
> path:   The path on the host that is identified by this fsdev.
>
> [aneesh.kumar@linux.vnet.ibm.com: Abstraction using FsContext]
> Signed-off-by: Gautham R Shenoy<ego@in.ibm.com>
> Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>
> ---
>   Makefile.objs      |    5 +++-
>   configure          |   24 +++++++++++++++++-
>   fsdev/qemu-fsdev.c |   70 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   fsdev/qemu-fsdev.h |   53 +++++++++++++++++++++++++++++++++++++++
>   hw/file-op-9p.h    |   32 +++++++++++++++++++++++
>   qemu-config.c      |   18 +++++++++++++
>   qemu-config.h      |    3 ++
>   qemu-options.hx    |   34 +++++++++++++++++++++++++
>   vl.c               |   27 ++++++++++++++++++++
>   9 files changed, 264 insertions(+), 2 deletions(-)
>   create mode 100644 fsdev/qemu-fsdev.c
>   create mode 100644 fsdev/qemu-fsdev.h
>   create mode 100644 hw/file-op-9p.h
>
> diff --git a/Makefile.objs b/Makefile.objs
> index ab1af88..4267239 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -35,6 +35,9 @@ net-nested-$(CONFIG_SLIRP) += slirp.o
>   net-nested-$(CONFIG_VDE) += vde.o
>   net-obj-y += $(addprefix net/, $(net-nested-y))
>
> +fsdev-nested-$(CONFIG_LINUX_VIRTFS) = qemu-fsdev.o
> +fsdev-obj-$(CONFIG_LINUX_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y))
>    

No need to make virtfs a config option.  Just use $(CONFIG_LINUX).

You also need to add fsdev to the list of directories that are created 
at the end of configure or else building from a seperate directory won't 
work.

Regards,

Anthony Liguori

  reply	other threads:[~2010-04-28 19:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15 14:10 [Qemu-devel] [PATCH -V5 00/21] virtio-9p: paravirtual file system passthrough Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 01/21] virtio-9p: Create a commandline option -fsdev Aneesh Kumar K.V
2010-04-28 19:53   ` Anthony Liguori [this message]
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 02/21] virtio-9p: Add a virtio 9p device to qemu Aneesh Kumar K.V
2010-04-28 19:52   ` Anthony Liguori
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 03/21] virtio-9p: pdu processing support Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 04/21] virtio-9p: Add string manipulation support Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 05/21] virtio-9p: Add minimal set of FileOperations Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 06/21] virtio-9p: Add fid and qid management support Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 07/21] virtio-9p: Add stat and mode related helper functions Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 08/21] virtio-9p: Add sg " Aneesh Kumar K.V
2010-04-15 14:10 ` [Qemu-devel] [PATCH -V5 09/21] virtio-9p: Add P9_TVERSION support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 10/21] virtio-9p: Add P9_TATTACH support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 11/21] virtio-9p: Add P9_TSTAT support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 12/21] virtio-9p: Add P9_TWALK support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 13/21] virtio-9p: Add P9_TOPEN support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 14/21] virtio-9p: Add P9_TREAD support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 15/21] virtio-9p: Add P9_TCLUNK support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 16/21] virtio-9p: Add P9_TWRITE support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 17/21] virtio-9p: Add P9_TCREATE support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 18/21] virtio-9p: Add P9_TWSTAT support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 19/21] virtio-9p: Add P9_TREMOVE support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 20/21] virtio-9p: Add P9_TFLUSH support Aneesh Kumar K.V
2010-04-15 14:11 ` [Qemu-devel] [PATCH -V5 21/21] virtio-9p: Create a syntactic shortcut for the file-system pass-thru Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD89248.3010901@linux.vnet.ibm.com \
    --to=aliguori@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=ego@in.ibm.com \
    --cc=ericvh@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).