From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O7DKo-0003P7-Fu for qemu-devel@nongnu.org; Wed, 28 Apr 2010 15:54:14 -0400 Received: from [140.186.70.92] (port=56383 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7DKi-0003AR-KN for qemu-devel@nongnu.org; Wed, 28 Apr 2010 15:54:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O7DKY-00031C-Vs for qemu-devel@nongnu.org; Wed, 28 Apr 2010 15:54:00 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:57172) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O7DKY-00030x-CK for qemu-devel@nongnu.org; Wed, 28 Apr 2010 15:53:58 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e39.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3SJjRQT023216 for ; Wed, 28 Apr 2010 13:45:28 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o3SJrnAP011692 for ; Wed, 28 Apr 2010 13:53:50 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o3SJrj7v018778 for ; Wed, 28 Apr 2010 13:53:46 -0600 Message-ID: <4BD89248.3010901@linux.vnet.ibm.com> Date: Wed, 28 Apr 2010 14:53:44 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH -V5 01/21] virtio-9p: Create a commandline option -fsdev References: <1271340671-19558-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1271340671-19558-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1271340671-19558-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: ericvh@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, Gautham R Shenoy On 04/15/2010 09:10 AM, Aneesh Kumar K.V wrote: > From: Gautham R Shenoy > > This patch creates a new command line option named -fsdev to hold any file > system specific information. > > The option will currently hold the following attributes: > -fsdev fstype id=id,path=path_to_share > where > fstype: Type of the file system. > id: Identifier used to refer to this fsdev > path: The path on the host that is identified by this fsdev. > > [aneesh.kumar@linux.vnet.ibm.com: Abstraction using FsContext] > Signed-off-by: Gautham R Shenoy > Signed-off-by: Aneesh Kumar K.V > --- > Makefile.objs | 5 +++- > configure | 24 +++++++++++++++++- > fsdev/qemu-fsdev.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > fsdev/qemu-fsdev.h | 53 +++++++++++++++++++++++++++++++++++++++ > hw/file-op-9p.h | 32 +++++++++++++++++++++++ > qemu-config.c | 18 +++++++++++++ > qemu-config.h | 3 ++ > qemu-options.hx | 34 +++++++++++++++++++++++++ > vl.c | 27 ++++++++++++++++++++ > 9 files changed, 264 insertions(+), 2 deletions(-) > create mode 100644 fsdev/qemu-fsdev.c > create mode 100644 fsdev/qemu-fsdev.h > create mode 100644 hw/file-op-9p.h > > diff --git a/Makefile.objs b/Makefile.objs > index ab1af88..4267239 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -35,6 +35,9 @@ net-nested-$(CONFIG_SLIRP) += slirp.o > net-nested-$(CONFIG_VDE) += vde.o > net-obj-y += $(addprefix net/, $(net-nested-y)) > > +fsdev-nested-$(CONFIG_LINUX_VIRTFS) = qemu-fsdev.o > +fsdev-obj-$(CONFIG_LINUX_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y)) > No need to make virtfs a config option. Just use $(CONFIG_LINUX). You also need to add fsdev to the list of directories that are created at the end of configure or else building from a seperate directory won't work. Regards, Anthony Liguori