From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O7QrV-0003PS-I3 for qemu-devel@nongnu.org; Thu, 29 Apr 2010 06:20:53 -0400 Received: from [140.186.70.92] (port=34191 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7QrT-0003P3-Og for qemu-devel@nongnu.org; Thu, 29 Apr 2010 06:20:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O7QrQ-00020v-Ii for qemu-devel@nongnu.org; Thu, 29 Apr 2010 06:20:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35943) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O7QrQ-00020m-8Y for qemu-devel@nongnu.org; Thu, 29 Apr 2010 06:20:48 -0400 Message-ID: <4BD955FB.8020308@redhat.com> Date: Thu, 29 Apr 2010 11:48:43 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1272470181-15846-1-git-send-email-kwolf@redhat.com> <1272470181-15846-2-git-send-email-kwolf@redhat.com> <4BD85BC8.50603@codemonkey.ws> In-Reply-To: <4BD85BC8.50603@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: dlaor@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, avi@redhat.com, danken@redhat.com Am 28.04.2010 18:01, schrieb Anthony Liguori: > On 04/28/2010 10:56 AM, Kevin Wolf wrote: >> This adds the wr_highest_sector blockstat which implements what is generally >> known as the high watermark. It is the highest offset of a sector written to >> the respective BlockDriverState since it has been opened. >> >> The query-blockstat QMP command is extended to add this value to the result, >> and also to add the statistics of the underlying protocol in a new "parent" >> field. Note that to get the "high watermark" of a qcow2 image, you need to look >> into the wr_highest_sector field of the parent (which can be a file, a >> host_device, ...). The wr_highest_sector of the qcow2 BlockDriverState itself >> is the highest offset on the _virtual_ disk that the guest has written to. >> >> Signed-off-by: Kevin Wolf >> > > I see, you did print out stats for each layer. > > I don't think we should take 2/2. I don't mind QMP having more features > than the user monitor. I agree, just posted it because it felt incomplete without it and I wanted to give you the choice. The only use case in the user monitor I saw for it would have been qemu development anyway. I can keep the patch in a local branch for this (or just rewrite it when/if I need it - it's small enough). Kevin