* [Qemu-devel] [PATCH] block: Release allocated options after bdrv_open
@ 2010-04-29 16:24 Jan Kiszka
2010-04-30 7:58 ` [Qemu-devel] " Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2010-04-29 16:24 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, Gerd Hoffmann
They aren't used afterwards nor supposed to be stored by a bdrv_create
handler.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
block.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index 7974215..f228d8d 100644
--- a/block.c
+++ b/block.c
@@ -411,6 +411,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
}
ret = bdrv_create(bdrv_qcow2, tmp_filename, options);
+ free_option_parameters(options);
if (ret < 0) {
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] block: Release allocated options after bdrv_open
2010-04-29 16:24 [Qemu-devel] [PATCH] block: Release allocated options after bdrv_open Jan Kiszka
@ 2010-04-30 7:58 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2010-04-30 7:58 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, Gerd Hoffmann
Am 29.04.2010 18:24, schrieb Jan Kiszka:
> They aren't used afterwards nor supposed to be stored by a bdrv_create
> handler.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-30 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-29 16:24 [Qemu-devel] [PATCH] block: Release allocated options after bdrv_open Jan Kiszka
2010-04-30 7:58 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).