From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] QMP: Add 'reason' member to the BLOCK_IO_ERROR event
Date: Mon, 03 May 2010 08:14:20 -0500 [thread overview]
Message-ID: <4BDECC2C.4010106@codemonkey.ws> (raw)
In-Reply-To: <20100429143008.72941474@redhat.com>
On 04/29/2010 12:30 PM, Luiz Capitulino wrote:
> On Wed, 28 Apr 2010 18:24:29 -0500
> Anthony Liguori<anthony@codemonkey.ws> wrote:
>
>
>> On 04/28/2010 03:32 PM, Luiz Capitulino wrote:
>>
>>> It's a parsable errno string representation, this is needed
>>> because some management tools want to base their action on
>>> the error cause.
>>>
>>> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>>>
>>>
>> Does anyone differentiate beyond ENOSPC and EIO?
>>
> For this specific case, I guess not.
>
> But this general solution is also needed in other places like
> savevm, loadvm and delvm I was working (and sent) an RFC last week,
> also I think other events and errors might need this in the near future.
>
> IOW, I expect this to be a QMP idiom.
>
I think that's a bit of a crutch. What's the point of QError if it's
just encapsulating errno's?
Regards,
Anthony Liguori
prev parent reply other threads:[~2010-05-03 13:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 20:32 [Qemu-devel] [PATCH 0/2]: QMP: expose errno in the BLOCK_IO_ERROR event Luiz Capitulino
2010-04-28 20:32 ` [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name() Luiz Capitulino
2010-05-03 13:06 ` Markus Armbruster
2010-05-03 13:16 ` Anthony Liguori
2010-05-04 13:56 ` Luiz Capitulino
2010-05-04 14:03 ` Anthony Liguori
2010-05-04 20:30 ` Luiz Capitulino
2010-05-04 21:56 ` Anthony Liguori
2010-05-05 15:00 ` Luiz Capitulino
2010-05-10 17:45 ` Markus Armbruster
2010-05-10 17:36 ` Markus Armbruster
2010-04-28 20:32 ` [Qemu-devel] [PATCH 2/2] QMP: Add 'reason' member to the BLOCK_IO_ERROR event Luiz Capitulino
2010-04-28 23:24 ` Anthony Liguori
2010-04-29 17:30 ` Luiz Capitulino
2010-05-03 13:14 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDECC2C.4010106@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).