From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O8vTm-0002l0-4K for qemu-devel@nongnu.org; Mon, 03 May 2010 09:14:34 -0400 Received: from [140.186.70.92] (port=42198 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O8vTk-0002jx-FS for qemu-devel@nongnu.org; Mon, 03 May 2010 09:14:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O8vTe-0002QK-9I for qemu-devel@nongnu.org; Mon, 03 May 2010 09:14:32 -0400 Received: from mail-qy0-f188.google.com ([209.85.221.188]:59977) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O8vTe-0002QB-6x for qemu-devel@nongnu.org; Mon, 03 May 2010 09:14:26 -0400 Received: by qyk26 with SMTP id 26so3815501qyk.19 for ; Mon, 03 May 2010 06:14:25 -0700 (PDT) Message-ID: <4BDECC2C.4010106@codemonkey.ws> Date: Mon, 03 May 2010 08:14:20 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] QMP: Add 'reason' member to the BLOCK_IO_ERROR event References: <1272486729-14771-1-git-send-email-lcapitulino@redhat.com> <1272486729-14771-3-git-send-email-lcapitulino@redhat.com> <4BD8C3AD.4080801@codemonkey.ws> <20100429143008.72941474@redhat.com> In-Reply-To: <20100429143008.72941474@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, armbru@redhat.com On 04/29/2010 12:30 PM, Luiz Capitulino wrote: > On Wed, 28 Apr 2010 18:24:29 -0500 > Anthony Liguori wrote: > > >> On 04/28/2010 03:32 PM, Luiz Capitulino wrote: >> >>> It's a parsable errno string representation, this is needed >>> because some management tools want to base their action on >>> the error cause. >>> >>> Signed-off-by: Luiz Capitulino >>> >>> >> Does anyone differentiate beyond ENOSPC and EIO? >> > For this specific case, I guess not. > > But this general solution is also needed in other places like > savevm, loadvm and delvm I was working (and sent) an RFC last week, > also I think other events and errors might need this in the near future. > > IOW, I expect this to be a QMP idiom. > I think that's a bit of a crutch. What's the point of QError if it's just encapsulating errno's? Regards, Anthony Liguori